Skip to content

Add implementation of ServerRequestInterface #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2017

Conversation

legionth
Copy link
Contributor

This PR adds an implementation of the PSR-7 ServerRequestInterface. The new ServerRequest is based on the Request implementation of this repo.

A following PR will add a function to parse a request string into a ServerRequest.

Verified

This commit was signed with the committer’s verified signature.
parkerbxyz Parker Brown

Verified

This commit was signed with the committer’s verified signature.
gr2m Gregor Martynus

Verified

This commit was signed with the committer’s verified signature.
parkerbxyz Parker Brown
@kirill-konshin
Copy link
Contributor

This repo is a fork, so the best is to sync it with the upstream. Guzzle PSR7 has an implementation https://github.com/guzzle/psr7/blob/master/src/ServerRequest.php which is slightly different than yours.

@kirill-konshin
Copy link
Contributor

I still don't see implementation of Guzzle's functions like fromGlobals and getUriFromGlobals. Please make sure that ServerRequest is a 1-to-1 mirror of Guzzle, except for 5.3 incompatible features.

@legionth
Copy link
Contributor Author

Thank you for your response!
The functions added by Guzzle are nice, but this PR is about adding a ServerRequest to this project. The added class is still open for extensions, but adding these extensions into this PR would make it far too big to review. I would suggest these extra Features should be added in several other PRs that have a focus on it.
This should be viewed similar to the Request class which is also no 1-to-1 mirror of Guzzle.

Do you disagree?

@kirill-konshin kirill-konshin merged commit 2fdf70d into ringcentral:master Apr 24, 2017
@kirill-konshin
Copy link
Contributor

Merged, but I hope you will find time to add missing things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants