Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holidays need duration #105

Open
okhowang opened this issue Dec 15, 2022 · 1 comment
Open

Holidays need duration #105

okhowang opened this issue Dec 15, 2022 · 1 comment

Comments

@okhowang
Copy link

In some country, holiday may last several days, for example china spring festival, korea lunar new year.
in #63, three holidays are defined. BeforeLunarNewYear/LunarNewYear/AfterLunarNewYear.
If holiday has duration, it can be more graceful
@rickar
Copy link
Owner

rickar commented Jan 10, 2023

Agreed. It may require a special flag to mark extended holidays so the existing logic is kept simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okhowang @rickar