Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded -rc argument for isort is depracated #6

Closed
abey79 opened this issue Aug 6, 2020 · 2 comments
Closed

Hardcoded -rc argument for isort is depracated #6

abey79 opened this issue Aug 6, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@abey79
Copy link

abey79 commented Aug 6, 2020

This action hardcodes -rc as argument to isort, but this triggers a deprecation warning:

 $ isort -rc -c --diff tests
/Users/hhip/src/vsketch/venv/lib/python3.8/site-packages/isort/main.py:771: UserWarning: 

The following deprecated CLI flags were used: -rc!
Please see the 5.0.0 upgrade guide:
        https://timothycrosley.github.io/isort/docs/upgrade_guides/5.0.0/

I suggest removing it altogether, it's easy to re-add via extra-isort-options if needed.

@ricardochaves ricardochaves added the enhancement New feature or request label Aug 14, 2020
@ricardochaves
Copy link
Owner

I created a release of Isort 5 v1.2.0. But Pylint is not working with isort 5. So a updated the README.md with this limitation and Ill follow the Pylint problem, when it's fixed I update the repo.

@ricardochaves
Copy link
Owner

Pylint now supports isort 5. I created a release v1.3.0 with isort 5, pylint 2.6.0 and I removed -rc from the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants