Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Electron 7.x #50

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Upgrade to Electron 7.x #50

merged 2 commits into from
Nov 7, 2019

Conversation

bampakoa
Copy link
Contributor

@bampakoa bampakoa commented Nov 5, 2019 •
edited

This PR introduces changes that have been marked as deprecated in the latest Electron version 7.x

  • Upgrade Electron dependency to 7.1.0
  • Use name property to get the application name

rhysd
rhysd approved these changes Nov 7, 2019
View reviewed changes
Copy link
Owner

@rhysd rhysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for sending helpful patch.

@rhysd rhysd merged commit 1db10cb into rhysd:master Nov 7, 2019
@rhysd rhysd mentioned this pull request Nov 7, 2019
Closed
@bampakoa bampakoa deleted the upgrade-electron branch November 7, 2019 10:03
@rhysd
Copy link
Owner

rhysd commented Nov 13, 2019

This is included in v1.13.2 https://github.com/rhysd/electron-about-window/releases/tag/v1.13.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhysd rhysd rhysd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bampakoa @rhysd