{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":390088655,"defaultBranch":"master","name":"cockroach","ownerLogin":"rhu713","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-07-27T18:32:07.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/17620970?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1696000103.0","currentOid":""},"activityList":{"items":[{"before":"b85ebe914744c9338c11ec6d7db69f38a0d5c6f1","after":"880fa5c3486a48152fbfa958001ba6cbccd1668f","ref":"refs/heads/rr-test","pushedAt":"2023-10-02T02:56:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"roachtest: add round trip backup restore test\n\nAdd a round trip backup and restore roachtest. This test runs several backups\nand backup verifications while a cluster is under load.\n\nThe patch also refactors the backup and backup verification logic introduced\nin the backup-restore/mixed-version test into a separate\n`BackupRestoreTestDriver` struct so that they can be used by both the mixed\nversion test and the new round trip test.\n\nRelease note: None","shortMessageHtmlLink":"roachtest: add round trip backup restore test"}},{"before":"73e373b8abbee9b134e8eb2d4e5932d5533e7acb","after":"b85ebe914744c9338c11ec6d7db69f38a0d5c6f1","ref":"refs/heads/rr-test","pushedAt":"2023-10-02T00:54:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"bbbeb4eb29e2c5f7c26313242c47fff7504c347f","after":"73e373b8abbee9b134e8eb2d4e5932d5533e7acb","ref":"refs/heads/rr-test","pushedAt":"2023-10-02T00:27:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"b989819fcd8fa87ff20aedb2131b9dbcde7a2a49","after":"bbbeb4eb29e2c5f7c26313242c47fff7504c347f","ref":"refs/heads/rr-test","pushedAt":"2023-10-02T00:11:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"4b2a92c15b5719ea6b77a132951eec025a6bb131","after":null,"ref":"refs/heads/backport23.1-104634","pushedAt":"2023-09-29T15:08:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"f8a61aaab6a8831427d0c52a02a7f9e0be87bbbf","after":"4b2a92c15b5719ea6b77a132951eec025a6bb131","ref":"refs/heads/backport23.1-104634","pushedAt":"2023-09-27T20:52:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"cloud,backupccl: add metric for time of last backup failure due to KMS\n\nAdd a metric `backup.last-failed-time.kms-inaccessible` that tracks the\ntimestamp of the last backup failure due to a KMS error. This metric is only\ntracked for BACKUP statrements that are executed with the OPTION\n`updates_cluster_monitoring_metrics` set.\n\nRelease note (sql change): adds the `updates_cluster_monitoring_metrics` backup\noption that allows an operator to opt-in tracking the timestamp\nof the last backup failure due to a KMS error.","shortMessageHtmlLink":"cloud,backupccl: add metric for time of last backup failure due to KMS"}},{"before":"afd6f301db23f88fc8d6f40b0cacccf72ce28652","after":"b989819fcd8fa87ff20aedb2131b9dbcde7a2a49","ref":"refs/heads/rr-test","pushedAt":"2023-09-27T17:30:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"roachtest: add round trip backup restore test\n\nAdd a round trip backup and restore roachtest. This test runs several backups\nand backup verifications while a cluster is under load.\n\nThe patch also refactors the backup and backup verification logic introduced\nin the backup-restore/mixed-version test into a separate\n`BackupRestoreTestDriver` struct so that they can be used by both the mixed\nversion test and the new round trip test.\n\nRelease note: None","shortMessageHtmlLink":"roachtest: add round trip backup restore test"}},{"before":"c0b4881e61a5a0b68755c104117a475962ee9664","after":"f8a61aaab6a8831427d0c52a02a7f9e0be87bbbf","ref":"refs/heads/backport23.1-104634","pushedAt":"2023-09-27T16:05:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"cloud,backupccl: add metric for time of last backup failure due to KMS\n\nAdd a metric `backup.last-failed-time.kms-inaccessible` that tracks the\ntimestamp of the last backup failure due to a KMS error. This metric is only\ntracked for BACKUP statrements that are executed with the OPTION\n`updates_cluster_monitoring_metrics` set.\n\nRelease note (sql change): adds the `updates_cluster_monitoring_metrics` backup\noption that allows an operator to opt-in tracking the timestamp\nof the last backup failure due to a KMS error.","shortMessageHtmlLink":"cloud,backupccl: add metric for time of last backup failure due to KMS"}},{"before":null,"after":"c0b4881e61a5a0b68755c104117a475962ee9664","ref":"refs/heads/backport23.1-104634","pushedAt":"2023-09-26T21:08:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":null,"after":"52387ccc3ee1fdff0dd6a0bfe7fe73a577244938","ref":"refs/heads/rr-test-scratch","pushedAt":"2023-09-26T21:05:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"e3d26eefecc500955df17363050f3d304b0efb88","after":"2ad9e79dca72ffcbaa39d65f0831fd2e6680e64d","ref":"refs/heads/kms-error","pushedAt":"2023-09-26T15:33:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"cloud,backupccl: add metric for time of last backup failure due to KMS\n\nAdd a metric `backup.last-failed-time.kms-inaccessible` that tracks the\ntimestamp of the last backup failure due to a KMS error. This metric is only\ntracked for BACKUP statrements that are executed with the OPTION\n`updates_cluster_monitoring_metrics` set.\n\nRelease note (sql change): adds the `updates_cluster_monitoring_metrics` backup\noption that allows an operator to opt-in tracking the timestamp\nof the last backup failure due to a KMS error.","shortMessageHtmlLink":"cloud,backupccl: add metric for time of last backup failure due to KMS"}},{"before":"d62484efddb0a9a659876ada4cb75066a6cbd48a","after":"e3d26eefecc500955df17363050f3d304b0efb88","ref":"refs/heads/kms-error","pushedAt":"2023-09-18T16:25:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"cloud,backupccl: add metric for time of last backup failure due to KMS\n\nAdd a metric `backup.last-failed-time.kms-inaccessible` that tracks the\ntimestamp of the last backup failure due to a KMS error. This metric is only\ntracked for BACKUP statrements that are executed with the OPTION\n`updates_cluster_monitoring_metrics` set.\n\nRelease note (sql change): adds the `updates_cluster_monitoring_metrics` backup\noption that allows an operator to opt-in tracking the timestamp\nof the last backup failure due to a KMS error.","shortMessageHtmlLink":"cloud,backupccl: add metric for time of last backup failure due to KMS"}},{"before":"3edfb7a6333e255e6ffca696c2b8869e3186ea8c","after":"d62484efddb0a9a659876ada4cb75066a6cbd48a","ref":"refs/heads/kms-error","pushedAt":"2023-09-18T13:58:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"84b90070d800b1b1ce4a872f49e683bcb0a4508f","after":"3edfb7a6333e255e6ffca696c2b8869e3186ea8c","ref":"refs/heads/kms-error","pushedAt":"2023-09-17T21:48:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"5aee60fe53a277a7fdc94911c0f2b18e08b8e33b","after":"84b90070d800b1b1ce4a872f49e683bcb0a4508f","ref":"refs/heads/kms-error","pushedAt":"2023-09-17T21:42:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"54b2e8938c915573f9b3d559637d1cc27026c7c1","after":"5aee60fe53a277a7fdc94911c0f2b18e08b8e33b","ref":"refs/heads/kms-error","pushedAt":"2023-09-17T19:56:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"2fb378de1e31448bd08ff2ed5d8b41432cbd8eb8","after":"54b2e8938c915573f9b3d559637d1cc27026c7c1","ref":"refs/heads/kms-error","pushedAt":"2023-09-15T22:00:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"11465982674cb889e254d7e1518116178e49c8cc","after":"2fb378de1e31448bd08ff2ed5d8b41432cbd8eb8","ref":"refs/heads/kms-error","pushedAt":"2023-09-13T17:46:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"cloud,backupccl: add metric for time of last scheduled backup fail due to KMS\n\nAdd a metric `schedules.BACKUP.last-failed-time.kms-inaccessible` that tracks\nthe timestamp of the last scheduled backup failure due to a KMS error. This\nmetric is only tracked for BACKUP schedules that are created with the SCHEDULE\nOPTION `updates_error_metrics` set.\n\nRelease note (sql change): adds the `updates_error_metrics` backup schedule\noption that allows an operator to opt-in tracking the timestamp of the timestamp\nof the last scheduled backup failure due to a KMS error.","shortMessageHtmlLink":"cloud,backupccl: add metric for time of last scheduled backup fail du…"}},{"before":"e6574269d2f73a51de1f05169d9cf71afd57378d","after":"afd6f301db23f88fc8d6f40b0cacccf72ce28652","ref":"refs/heads/rr-test","pushedAt":"2023-09-12T22:36:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"refactor common test utils","shortMessageHtmlLink":"refactor common test utils"}},{"before":"fcd3022448b39b6b76e4a5d62edf88cf8af43339","after":"e6574269d2f73a51de1f05169d9cf71afd57378d","ref":"refs/heads/rr-test","pushedAt":"2023-09-12T22:30:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"a468c4adc12c4f294f784bd63c8343e8cdb91f74","after":"fcd3022448b39b6b76e4a5d62edf88cf8af43339","ref":"refs/heads/rr-test","pushedAt":"2023-09-12T14:56:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"3a6904f73bf27bf917e0e025adf963d742f2a9dd","after":"1d5395483a56e249a7309c5b53ac9db410ddc952","ref":"refs/heads/mixed-version-system-db","pushedAt":"2023-09-08T17:23:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"roachtest: backup-restore/mixed-version use system db when querying job status\n\nPreviously in `waitForJobSuccess()` in the backup-restore/mixed-version test,\nif the job was a full cluster restore that dropped `defaultdb`, the query to\nthe jobs table would fail with `pq: database \"defaultdb\" is offline: restoring`\nas our connection was to `defaultdb`, which is dropped during full cluster\nrestore. We fix this by adding an option to connect to a different database\nin roachtests and connecting to the system database in `waitForJobSuccess()`\ninstead.\n\nFixes #110165\n\nRelease note: None","shortMessageHtmlLink":"roachtest: backup-restore/mixed-version use system db when querying j…"}},{"before":"9cfa0f07cdda891e8bff2705c79b79d51fcd43d8","after":"3a6904f73bf27bf917e0e025adf963d742f2a9dd","ref":"refs/heads/mixed-version-system-db","pushedAt":"2023-09-08T17:19:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"60f85a4a6f5e5a5b2fbe8e3e8af43a4c5ada07ac","after":"9cfa0f07cdda891e8bff2705c79b79d51fcd43d8","ref":"refs/heads/mixed-version-system-db","pushedAt":"2023-09-08T17:18:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"b38c0a33205bed136253f9a9628ed63a2c0194c2","after":"60f85a4a6f5e5a5b2fbe8e3e8af43a4c5ada07ac","ref":"refs/heads/mixed-version-system-db","pushedAt":"2023-09-08T17:18:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"c404bc64527072b28c289a8a0fa288d6a93a8961","after":"b38c0a33205bed136253f9a9628ed63a2c0194c2","ref":"refs/heads/mixed-version-system-db","pushedAt":"2023-09-08T17:11:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"33c05c75084fc6dd4454e0b5bd6ff5e2989a8a94","after":"c404bc64527072b28c289a8a0fa288d6a93a8961","ref":"refs/heads/mixed-version-system-db","pushedAt":"2023-09-07T20:51:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"roachtest: backup-restore/mixed-version use system db when querying job status\n\nPreviously in `waitForJobSuccess()` in the backup-restore/mixed-version test,\nif the job was a full cluster restore that dropped `defaultdb`, the query to\nthe jobs table would fail with `pq: database \"defaultdb\" is offline: restoring`\nas our connection was to `defaultdb`, which is dropped during full cluster\nrestore. We fix this by adding an option to connect to a different database\nin roachtests and connecting to the system database in `waitForJobSuccess()`\ninstead.\n\nFixes #110165\n\nRelease note: None","shortMessageHtmlLink":"roachtest: backup-restore/mixed-version use system db when querying j…"}},{"before":null,"after":"33c05c75084fc6dd4454e0b5bd6ff5e2989a8a94","ref":"refs/heads/mixed-version-system-db","pushedAt":"2023-09-07T20:13:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"}},{"before":"c08bc24c6eed7b8ee58a5d3f8efdba6059f6a8c1","after":"a468c4adc12c4f294f784bd63c8343e8cdb91f74","ref":"refs/heads/rr-test","pushedAt":"2023-09-06T20:51:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"717eee3aed02001a0d0d6fdc3e1ecd93b64fbfff","after":"6410bf11018131e424acaed549da90cde7fe4bb7","ref":"refs/heads/backport22.2-109750","pushedAt":"2023-09-05T17:03:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rhu713","name":"Rui Hu","path":"/rhu713","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17620970?s=80&v=4"},"commit":{"message":"backupccl: during restore, do not .Next() any keys in makeSimpleImportSpans\n\nPreviously, if `bulkio.restore.use_simple_import_spans` was true during\nrestore, makeSimpleImportSpans called .Next() on all end keys of its input\nfile spans in order to handle the fact that these spans are end keys are end\nkey inclusive. This resulted in some spans having start or end keys that are\nnot valid for splitting. This patch removes all .Next() calls in\nmakeSimpleImportSpans, and instead addresses the end key inclusive file spans\nby constantly keeping track of all files that do not have their end points\ncovered as the covering is created, and immediately populating the next cover\nentry with these files.\n\nThis fixes an issue where a split can be called on an invalid key that's in the\nform of someValidKey.Next() during restore. These invalid keys will generally\nhave a NULL at the end of the key, which will result in an error when calling\nEnsureSafeSplits on this split key. Currently errors from EnsureSafeSplits\nare ignored, and thus a split will always be attempted on this type of invalid\nsplit key. This split key can land in the middle of a row with column families,\nand thus result in failing SQL queries when querying the restored table.\n\nThis patch adds some additional testing for backup manifest file entries with\nzero sized spans. The previous .Next() called on all file spans meant that\nthere were no zero sized spans, so backups with these types of files were\nunder tested.\n\nInforms: #109483\n\nRelease note (bug fix): Fixes an issue where a split can be called on an\ninvalid key that's in the form of someValidKey.Next() during restore\nwith `bulkio.restore.use_simple_import_spans=true`. This\nsplit key can land in the middle of a row with column families, and thus result\nin failing SQL queries when querying the restored table.","shortMessageHtmlLink":"backupccl: during restore, do not .Next() any keys in makeSimpleImpor…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADjREPMAA","startCursor":null,"endCursor":null}},"title":"Activity · rhu713/cockroach"}