Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable reconcileRevertsManualChanges test #142

Closed
jan--f opened this issue May 19, 2022 · 1 comment · Fixed by #173
Closed

Reenable reconcileRevertsManualChanges test #142

jan--f opened this issue May 19, 2022 · 1 comment · Fixed by #173

Comments

@jan--f
Copy link
Collaborator

jan--f commented May 19, 2022

Once the prometheus crd yaml manifest carries the expected atomic marker on LabelSelector fields, we should reenable this test. Until then we'll skip.

See also:
kubernetes-sigs/controller-tools#676
@jan--f
Copy link
Collaborator Author

jan--f commented Jul 6, 2022

This is fixed in kubernetes-sigs/controller-tools#692 and via kubernetes-sigs/controller-tools#693 shipped in controller-tools v0.9.1.

jan--f added a commit to jan--f/observability-operator that referenced this issue Jul 6, 2022
@jan--f
chore: update controller-gen to v0.9.1
dc3c96b 
This mostly pulls in many fixes from controller-tools. Mainly
controller-gen now respects type marker in types and generated the CRD
manifests accordingly. This means that SSA now functions correctly with
the generated manifests. Accordingly this also reenables the
`revert-test`.
The other changes added here are mostly whitespace changes in the
manifests, the status being no longer included in the CRD manifests (see
kubernetes-sigs/controller-tools#456 for
details) and we seem to have forgotten to regenerate some manifests
after a version bump.

Fixes: rhobs#142

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@jan--f jan--f mentioned this issue Jul 6, 2022
Merged
jan--f added a commit to jan--f/observability-operator that referenced this issue Jul 6, 2022
@jan--f
chore: update controller-gen to v0.9.1
ec323c8 
This mostly pulls in many fixes from controller-tools. Mainly
controller-gen now respects type marker in types and generated the CRD
manifests accordingly. This means that SSA now functions correctly with
the generated manifests. Accordingly this also reenables the
`revert-test`.
The other changes added here are mostly whitespace changes in the
manifests, the status being no longer included in the CRD manifests (see
kubernetes-sigs/controller-tools#456 for
details) and we seem to have forgotten to regenerate some manifests
after a version bump.

Fixes: rhobs#142

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f added a commit to jan--f/observability-operator that referenced this issue Jul 8, 2022
@jan--f
chore: update controller-gen to v0.9.2
320f18f 
This mostly pulls in many fixes from controller-tools. Mainly
controller-gen now respects type marker in types and generated the CRD
manifests accordingly. This means that SSA now functions correctly with
the generated manifests. Accordingly this also reenables the
`revert-test`.
The other changes added here are mostly whitespace changes in the
manifests, the status being no longer included in the CRD manifests (see
kubernetes-sigs/controller-tools#456 for
details) and we seem to have forgotten to regenerate some manifests
after a version bump.

Fixes: rhobs#142

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f added a commit to jan--f/observability-operator that referenced this issue Jul 11, 2022
@jan--f
chore: update controller-gen to v0.9.2
415db4e 
This mostly pulls in many fixes from controller-tools. Mainly
controller-gen now respects type marker in types and generated the CRD
manifests accordingly. This means that SSA now functions correctly with
the generated manifests. Accordingly this also reenables the
`revert-test`.
The other changes added here are mostly whitespace changes in the
manifests, the status being no longer included in the CRD manifests (see
kubernetes-sigs/controller-tools#456 for
details) and we seem to have forgotten to regenerate some manifests
after a version bump.

Fixes: rhobs#142

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
sthaha pushed a commit that referenced this issue Jul 12, 2022
@jan--f
chore: update controller-gen to v0.9.2
7596280 
This mostly pulls in many fixes from controller-tools. Mainly
controller-gen now respects type marker in types and generated the CRD
manifests accordingly. This means that SSA now functions correctly with
the generated manifests. Accordingly this also reenables the
`revert-test`.
The other changes added here are mostly whitespace changes in the
manifests, the status being no longer included in the CRD manifests (see
kubernetes-sigs/controller-tools#456 for
details) and we seem to have forgotten to regenerate some manifests
after a version bump.

The patch also updates  kustomize to 4.5.2

Fixes: #142

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update controller-gen to v0.9.2 jan--f/observability-operator
1 participant
@jan--f