Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested dialog, html hidden style not disappearing bug #118

Open
smblee opened this issue Sep 28, 2022 · 0 comments
Open

Nested dialog, html hidden style not disappearing bug #118

smblee opened this issue Sep 28, 2022 · 0 comments

Comments

@smblee
Copy link

smblee commented Sep 28, 2022

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch @rgossiaux/svelte-headlessui@1.0.2 for the project I'm working on.

With nested Dialogs + svelte animations, I noticed hidden flag not being removed due to race conditions of how Dialogs close/unmount.

Here is the diff that solved my problem:

diff --git a/node_modules/@rgossiaux/svelte-headlessui/components/dialog/Dialog.svelte b/node_modules/@rgossiaux/svelte-headlessui/components/dialog/Dialog.svelte
index 03ab5c5..bbfb7a0 100644
--- a/node_modules/@rgossiaux/svelte-headlessui/components/dialog/Dialog.svelte
+++ b/node_modules/@rgossiaux/svelte-headlessui/components/dialog/Dialog.svelte
@@ -135,6 +135,9 @@ $: _cleanupScrollLock = (() => {
         return;
     if (!mounted)
         return;
+    if (document.documentElement.style.overflow === 'hidden') {
+        return;
+    }
     let overflow = document.documentElement.style.overflow;
     let paddingRight = document.documentElement.style.paddingRight;
     let scrollbarWidth = window.innerWidth - document.documentElement.clientWidth;

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant