Allow BITBUCKET_SERVER_URL to have subpath #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow BITBUCKER_SERVER_URL to have a subpath fix reviewdog#1124
Fix some typos in the existing error messages. Distinguish between Bitbucket Cloud and Bitbucket Server for API errors.
haya14busa
approved these changes
Apr 20, 2022
ST1005: error strings should not be capitalized (stylecheck)
|
sry for the late review. |
|
Hi, @lgellrich! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the parsing of BITBUCKET_SERVER_URL with subpath #1124
Fix the parsing by including the path into client configuration
Add test cases for the parsing
Fix typos in error messages
Distinguish between Bitbucket Cloud and Bitbucket Server for API errors
Updated Unreleased section in CHANGELOG or it's not notable changes.