You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to use Vale for checking the documentation quality of markdown files added or changed in a pull request. I trigger Vale with the following GitHub Actions workflow:
Packages = Microsoft
StylesPath = .vale/styles
Vocab = Ours
MinAlertLevel = suggestion
[*.md]
BasedOnStyles = Vale, Microsoft
The GitHub Actions job gets triggered as expected when a pull request is opened or updated with more commits, but the reviewdog filtering isn't behaving as expected. It doesn't fail the job and doesn't filter the results. I expect the job to fail and reviewdog to add decoration to the pull request only for the files that have been changed.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi!
I want to use Vale for checking the documentation quality of markdown files added or changed in a pull request. I trigger Vale with the following GitHub Actions workflow:
The Vale settings file:
The GitHub Actions job gets triggered as expected when a pull request is opened or updated with more commits, but the reviewdog filtering isn't behaving as expected. It doesn't fail the job and doesn't filter the results. I expect the job to fail and reviewdog to add decoration to the pull request only for the files that have been changed.
Beta Was this translation helpful? Give feedback.
All reactions