Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout does not cause failing check #27

Open
jszwedko opened this issue Apr 9, 2020 · 2 comments
Open

Timeout does not cause failing check #27

jszwedko opened this issue Apr 9, 2020 · 2 comments

Comments

@jszwedko
Copy link

jszwedko commented Apr 9, 2020 •
edited

We noticed that our check was reporting false negatives because golangci-lint timed out.

I think we could catch that by looking at the exit code: https://github.com/golangci/golangci-lint/blob/master/pkg/exitcodes/exitcodes.go#L8
@eddycharly
Copy link

Just noticed the same issue, any plan to fix ?

jimmidyson added a commit to nutanix-cloud-native/cluster-api-runtime-extensions-nutanix that referenced this issue Oct 11, 2023
@jimmidyson
build: Increase golangci-lint timeout for slower GHA runners
cc78ae3 
Without this, the reviewdog/action-golangci-lint action can give false
positives. See reviewdog/action-golangci-lint#27
for details.

This occurred in a GHA run in
https://github.com/d2iq-labs/capi-runtime-extensions/actions/runs/6451051901/job/17511173049?pr=192#step:5:88.
@jimmidyson jimmidyson mentioned this issue Oct 11, 2023
Merged
@sebastianbuechler
Copy link

sebastianbuechler commented Oct 18, 2023 •
edited

I think that's fixed by #622, especially 6a7cced

@duoertai duoertai mentioned this issue Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jszwedko @sebastianbuechler @eddycharly