Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail_on_error does not work for golangci-lint #142

Open
ivvist opened this issue Sep 30, 2021 · 2 comments
Open

fail_on_error does not work for golangci-lint #142

ivvist opened this issue Sep 30, 2021 · 2 comments

Comments

@ivvist
Copy link

ivvist commented Sep 30, 2021

Hi,
My github action yml is simple:

name: reviewdog
on: [push, pull_request]
jobs:
golangci-lint:
runs-on: ubuntu-latest
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@v2
- name: golangci-lint
uses: reviewdog/action-golangci-lint@v2
with:
fail_on_error: true

In Github actions I see the result:
But test looks as passed - it's green

111

I need to notify user that linter catch the error and commit is bad.
How can I make it Red?

@shogo82148
Copy link
Contributor

The build log says "this is not PullRequest build".
reviewdog doesn't fail in this case.

please show me the build log on the pull_request event.

@ivvist
Copy link
Author

ivvist commented Oct 2, 2021

True, this was not pull request event, that was just push.
But every time I make push I need to know all errors linter gives me as well as during pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants