From abd468f5b5943ef589b9f15f31241370e64dd4b8 Mon Sep 17 00:00:00 2001 From: Ichinose Shogo Date: Tue, 6 Apr 2021 08:32:35 +0900 Subject: [PATCH 1/3] bump actions/checkout v2 in README --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 6da47785..6e4b7504 100644 --- a/README.md +++ b/README.md @@ -75,7 +75,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code into the Go module directory - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: golangci-lint uses: reviewdog/action-golangci-lint@v1 ``` @@ -96,7 +96,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code into the Go module directory - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: golangci-lint uses: reviewdog/action-golangci-lint@v1 with: @@ -111,7 +111,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code into the Go module directory - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: golint uses: reviewdog/action-golangci-lint@v1 with: @@ -125,7 +125,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code into the Go module directory - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: errcheck uses: reviewdog/action-golangci-lint@v1 with: @@ -147,7 +147,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code into the Go module directory - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: golangci-lint uses: reviewdog/action-golangci-lint@v1 with: From 4825a3558711bfcf60dc18f1f117127d9e8ad568 Mon Sep 17 00:00:00 2001 From: Ichinose Shogo Date: Tue, 6 Apr 2021 08:44:28 +0900 Subject: [PATCH 2/3] add a setting up Go step into the example addresses https://github.com/reviewdog/action-golangci-lint/issues/73#issuecomment-813386935 > You need to configure the `GOROOT` environment correctly. > golangci-lint looks up the standard libraries from `GOROOT`. https://github.com/golangci/golangci-lint/blob/a833cc1600456c38357bb6f8abbd6f5aef7dbc51/pkg/lint/load.go#L54-L65 > > It looks that it points Go 1.15 by default on `ubuntu-20.04`. > So golangci-lint can't find the functions introduced from Go 1.16. > Using https://github.com/actions/setup-go is easiest way. --- README.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index 6e4b7504..f4449bd3 100644 --- a/README.md +++ b/README.md @@ -76,6 +76,13 @@ jobs: steps: - name: Check out code into the Go module directory uses: actions/checkout@v2 + + # optionally use a specific version of Go rather than the default one + - name: Set up Go + uses: actions/setup-go@v2 + with: + go-version: '1.16' + - name: golangci-lint uses: reviewdog/action-golangci-lint@v1 ``` From 2a604336fa1412a4cf2ab46f3159e06f930b2f56 Mon Sep 17 00:00:00 2001 From: Ichinose Shogo Date: Fri, 30 Apr 2021 00:17:23 +0900 Subject: [PATCH 3/3] bump actions/checkout v2 --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a239c10c..12ffcc51 100644 --- a/README.md +++ b/README.md @@ -146,7 +146,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code into the Go module directory - uses: actions/checkout@v1 + uses: actions/checkout@v2 - uses: actions/cache@v2 with: