fix: github-pr-review path's black_check_output value #57
Conversation
… regenerate normal value
|
ping @haya14busa san, @rickstaa san |
|
@tsuyoshicho Sorry for the late reply. I'm very busy with my graduation, so I didn't yet find the time to look at this PR. Maybe @haya14busa or @chadsr have time to look at it. |
entrypoint.sh
Outdated
| # read and drop exit code | ||
| black_exit_val2="0" | ||
| # shellcheck disable=SC2086,SC2034 | ||
| black_check_output="$(black --check . ${INPUT_BLACK_ARGS} 2>&1)" || |
There was a problem hiding this comment.
@tsuyoshicho I think this can be changed to black_check_output="$(black --check . ${INPUT_BLACK_ARGS} 2>&1)" || true since we don't use the exit code.
entrypoint.sh
Outdated
| @@ -39,6 +39,14 @@ if [[ "${INPUT_REPORTER}" = 'github-pr-review' ]]; then | |||
| -level="${INPUT_LEVEL}" \ | |||
| -fail-on-error="${INPUT_FAIL_ON_ERROR}" \ | |||
| ${INPUT_REVIEWDOG_FLAGS} || reviewdog_exit_val="$?" | |||
|
|
|||
| # regenerate black_check_output that command same as non-github-pr-review. | |||
There was a problem hiding this comment.
Maybe the shorter Re-generate black output. Needed because the output of the '--diff' option can not be used to retrieve the files that black would change is enough.
|
@tsuyoshicho I went through your pull request. I think your pull request looks good (see my suggestions above). I created a pull request on your fork with these changes (see tsuyoshicho#1). This pull request also contains extra documentation for the |
This commit makes sure that the Jupyter warning that is thrown by black when Jupyter is not installed and the repo contains `.ipynb` files does not show in the `BLACK_CHECK_FILE_PATHS` variable. It also adds documentaiton for the `BLACK_CHECK_FILE_PATHS`.
fix: filter jupyter warning and improve readme
|
Thanks your fix PR. Good job! |
|
LGTM thanks for the contribution! |
|
@rickstaa There seems to be no update for "black" for a while, so could you please release it? |
|
@tsuyoshicho Oh, I forgot to add the |
Close #56
In github-pr-review:
regenerate with normal command result.