Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composite action like reviewdog/action-flake8 #43

Merged
merged 2 commits into from Sep 16, 2021

Conversation

weargoggles
Copy link
Contributor

I had difficulty building the Dockerfile based action on GitHub Enterprise.

Switching the action to be a composite action like reviewdog/action-flake8#28 made it work, and faster too.

@rickstaa
Copy link
Member

rickstaa commented Sep 16, 2021

@weargoggles Amazing. Thanks a lot for your contribution! I was planing to implement this but did not yet find the time to do so. I will test your PR somewhere this weekend.

@rickstaa rickstaa self-requested a review September 16, 2021 17:53
@rickstaa rickstaa added the bump:major Bump the major version on pull request label Sep 16, 2021
@rickstaa rickstaa merged commit 2de44fd into reviewdog:master Sep 16, 2021
@review-dog
Copy link
Member

Hi, @weargoggles! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.

Thanks again!

@github-actions
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v3.0.0 Changes:v2.3.0...v3.0.0

@rickstaa
Copy link
Member

@weargoggles Thanks again for your contribution and welcome to the Reviewdog team! Your changes are released under https://github.com/reviewdog/action-black/releases/tag/v3.0.0.

@weargoggles weargoggles deleted the switch-to-composite branch September 16, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:major Bump the major version on pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants