{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":3355797,"defaultBranch":"master","name":"ReviewBot","ownerLogin":"reviewboard","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-02-04T22:20:19.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/118199?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1711580954.0","currentOid":""},"activityList":{"items":[{"before":"56e10f71a22460f2e6ea710097082a6b5c78ad65","after":"d52bd2ac53f0c9087a273d69fe043b8c6546777e","ref":"refs/heads/release-4.x","pushedAt":"2024-04-16T22:15:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Update version compatibility in Review Bot docs.\n\nThis change updates the version compatibility notes for Review Bot 4 in\ntwo places:\n\n- The main documentation index now correctly lists our current Review\n Board and Python compatibility.\n- The PMD tool page lists the compatible PMD major versions.\n\nTesting Done:\nBuilt docs.\n\nReviewed at https://reviews.reviewboard.org/r/13732/","shortMessageHtmlLink":"Update version compatibility in Review Bot docs."}},{"before":"b244a570344d4b169cd660fff668665e663efad8","after":"e0a98bab94a193b4de951eb92365c4656357953c","ref":"refs/heads/master","pushedAt":"2024-04-10T21:33:15.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Merge branch 'release-4.x'","shortMessageHtmlLink":"Merge branch 'release-4.x'"}},{"before":"e31611abd051d4c8c5e489323ca781dd99db8584","after":"56e10f71a22460f2e6ea710097082a6b5c78ad65","ref":"refs/heads/release-4.x","pushedAt":"2024-04-10T21:33:02.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Add draft release notes for Review Bot 4.\n\nReview Bot 4 is just a modernization release, so the release notes are\nbasically just the compatibility matrix.\n\nReviewed at https://reviews.reviewboard.org/r/13697/","shortMessageHtmlLink":"Add draft release notes for Review Bot 4."}},{"before":"3f26161f4cf52f5cc5ec296546f667b0fca9af92","after":"e31611abd051d4c8c5e489323ca781dd99db8584","ref":"refs/heads/release-4.x","pushedAt":"2024-04-09T16:12:33.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Change \"unicode\" to \"str\" throughout the worker codebase.\n\nThis changes all our doc comments for types from the old python 2\n\"unicode\" to the python 3 \"str\".\n\nTesting Done:\nRan unit tests.\n\nReviewed at https://reviews.reviewboard.org/r/13709/","shortMessageHtmlLink":"Change \"unicode\" to \"str\" throughout the worker codebase."}},{"before":"632810b7598edd2166bd550ffa0b23dc174a970d","after":"b244a570344d4b169cd660fff668665e663efad8","ref":"refs/heads/master","pushedAt":"2024-03-27T23:09:30.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Merge branch 'release-4.x'","shortMessageHtmlLink":"Merge branch 'release-4.x'"}},{"before":null,"after":"3f26161f4cf52f5cc5ec296546f667b0fca9af92","ref":"refs/heads/release-4.x","pushedAt":"2024-03-27T23:09:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Bump versions to 4.0\n\nThis change bumps the package versions for the new release-4.x branch.","shortMessageHtmlLink":"Bump versions to 4.0"}},{"before":"1f0ce4f88b170bc355e087ade191e8defca010ee","after":"632810b7598edd2166bd550ffa0b23dc174a970d","ref":"refs/heads/master","pushedAt":"2024-03-25T16:02:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Update dependencies for Review Bot worker.\n\nThis change updates our dependency list for the Review Bot worker to use\nthe current version of Celery and remove the pinned versions that we had\nto maintain support for old versions of Python.\n\nTesting Done:\nRan the Review Bot worker.\n\nReviewed at https://reviews.reviewboard.org/r/13640/","shortMessageHtmlLink":"Update dependencies for Review Bot worker."}},{"before":"b59b566e127b5ef1b08f3189f1aa0194b7437d94","after":"1f0ce4f88b170bc355e087ade191e8defca010ee","ref":"refs/heads/master","pushedAt":"2024-03-18T20:17:11.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Move from ugettext* to gettext*.\n\nThis change moves us from the old unicode-specific `gettext` APIs to the\nmodern names. This is required to run against Django 4+\n\nTesting Done:\nRan the Review Bot extension on RB7.\n\nReviewed at https://reviews.reviewboard.org/r/13639/","shortMessageHtmlLink":"Move from ugettext* to gettext*."}},{"before":"a7cce0b16292778dcffe45731f61a3df531063be","after":"366faa27ca4852675e5b09e82f9c1f27559c9dff","ref":"refs/heads/release-3.x","pushedAt":"2023-05-31T22:36:36.962Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Update Review Bot to always use pip for developer mode.\n\n`setup.py develop` uses legacy Python eggs and `easy_install` behavior,\nwhich makes it very difficult to test modern compatibility with\npackages, and causes headaches in CI.\n\nTo keep things manageable until we eventually move to `pyproject.toml`,\nthis change brings over our standard `setup.py develop` override that\nforces usage of `pip`.\n\nTesting Done:\nSuccessfully installed both in development mode.\n\nReviewed at https://reviews.reviewboard.org/r/13085/","shortMessageHtmlLink":"Update Review Bot to always use pip for developer mode."}},{"before":"6bde83de7da97b3a921fc11ce2ee86da11a19df1","after":"b59b566e127b5ef1b08f3189f1aa0194b7437d94","ref":"refs/heads/master","pushedAt":"2023-05-31T22:36:36.962Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge branch 'release-3.x'","shortMessageHtmlLink":"Merge branch 'release-3.x'"}},{"before":"56f840aab3635d976d4ac5a4962335249f9b6d07","after":"6bde83de7da97b3a921fc11ce2ee86da11a19df1","ref":"refs/heads/master","pushedAt":"2023-05-31T21:52:45.182Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge branch 'release-3.x'","shortMessageHtmlLink":"Merge branch 'release-3.x'"}},{"before":"f99c284b0aae0c7a695b42031e3289f54de41e33","after":"a7cce0b16292778dcffe45731f61a3df531063be","ref":"refs/heads/release-3.x","pushedAt":"2023-05-31T21:52:45.182Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Limit the new importlib-metadata cap to Python 3.7.\n\nPython 2.7 broke when introducing the `importlib-metadata` cap. Since we\nreally only need this for the version of Celery used with Python 3.7,\nthis change limits the cap to that version.\n\nThis is a trivial change.","shortMessageHtmlLink":"Limit the new importlib-metadata cap to Python 3.7."}},{"before":"7d2fa4d624a2500db46b1721d1ff6a81da9fa721","after":"56f840aab3635d976d4ac5a4962335249f9b6d07","ref":"refs/heads/master","pushedAt":"2023-05-31T21:48:07.215Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge branch 'release-3.x'","shortMessageHtmlLink":"Merge branch 'release-3.x'"}},{"before":"b572fdae581cea82df705f323e139fe21f16d916","after":"f99c284b0aae0c7a695b42031e3289f54de41e33","ref":"refs/heads/release-3.x","pushedAt":"2023-05-31T21:48:07.215Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Cap the version of importlib-metadata on Python <= 3.7.\n\nCelery 5.2.7 fails to import on Python 3.7 environments when\n`importlib-metadata` >= 5.0 is installed. The `celery.Celery` import\nfails.\n\nTo resolve this, we need to cap `importlib-metadata` on older versions\nof Python.\n\nTesting Done:\nSuccessfully installed on a Python 3.7 environment and verified that\n`celery.Celery` could be imported.\n\nReviewed at https://reviews.reviewboard.org/r/13083/","shortMessageHtmlLink":"Cap the version of importlib-metadata on Python <= 3.7."}},{"before":"1c001eb863ad7376abb3f391f4a8ad709ccd1f58","after":"7d2fa4d624a2500db46b1721d1ff6a81da9fa721","ref":"refs/heads/master","pushedAt":"2023-05-31T04:13:06.778Z","pushType":"push","commitsCount":3,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge branch 'release-3.x'","shortMessageHtmlLink":"Merge branch 'release-3.x'"}},{"before":"deaa803adbeabc303890a363da717155abd7b82f","after":"b572fdae581cea82df705f323e139fe21f16d916","ref":"refs/heads/release-3.x","pushedAt":"2023-05-31T04:13:06.778Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Update unit tests for Cargo 1.69.\n\nCargo 1.69 changed the lint results for our syntax error unit tests.\nThis updates the test results to check for both variations. For the\nmoment, the simulation test retains the results from 1.68.2.\n\nTesting Done:\nUnit tests pass against both Cargo 1.68.2 and 1.69.\n\nReviewed at https://reviews.reviewboard.org/r/13082/","shortMessageHtmlLink":"Update unit tests for Cargo 1.69."}},{"before":"c958cf6bd80ec8b76dd4f737206ce2c168f645bb","after":"1c001eb863ad7376abb3f391f4a8ad709ccd1f58","ref":"refs/heads/master","pushedAt":"2023-05-31T03:44:44.403Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge branch 'release-3.x'","shortMessageHtmlLink":"Merge branch 'release-3.x'"}},{"before":"36f6ee763428f4da9bed00cb79f9d99d76573c9f","after":"deaa803adbeabc303890a363da717155abd7b82f","ref":"refs/heads/release-3.x","pushedAt":"2023-05-31T03:44:44.403Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Cap the kombu and RBTools dependencies on Python < 3.8.\n\nKombu is dropping Python 3.7 support in their upcoming 5.3 releases,\nwhich are available on PyPI right now as pre-releases. When installing\nReview Bot via eggs, `easy_install` doesn't know to avoid pre-releases\n(or to consider supported Python version metadata), so we have to cap\nthis until we drop support for Python 2.7 and can depend fully on\nwheels.\n\nRBTools dropped Python 2.7 and 3.6 in RBTools 4. We had a pretty old\nminimum version, so I've taken the opportunity to bump that up. We now\ndepend on RBTools 3.x for Python 2.7/3.7, and RBTools 4.x or higher for\nnewer releases.\n\nTesting Done:\nSuccessfully installed into new Python 2.7, 3.7, and 3.8 environments.\n\nReviewed at https://reviews.reviewboard.org/r/13081/","shortMessageHtmlLink":"Cap the kombu and RBTools dependencies on Python < 3.8."}},{"before":"139880f7cb02691b09ff33851d22551bfac0341d","after":"c958cf6bd80ec8b76dd4f737206ce2c168f645bb","ref":"refs/heads/master","pushedAt":"2023-05-31T03:21:32.006Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge branch 'release-3.x'","shortMessageHtmlLink":"Merge branch 'release-3.x'"}},{"before":"7424de7bac07cb741130d28a006d057d03b528f5","after":"36f6ee763428f4da9bed00cb79f9d99d76573c9f","ref":"refs/heads/release-3.x","pushedAt":"2023-05-31T03:21:21.025Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix RuboCop unit tests on modern versions.\n\nModern versions of RuboCop show syntax errors as a \"fatal\" type instead\nof an \"error\" type, which is certainly more reasonable. This updates the\nunit tests to test against this expectation.\n\nNo changes are needed for the main RuboCop integration.\n\nTesting Done:\nUpgraded RuboCop locally and ran unit tests. Verified the fix.\n\nReviewed at https://reviews.reviewboard.org/r/13080/","shortMessageHtmlLink":"Fix RuboCop unit tests on modern versions."}},{"before":"7c3704ce15980ef58ef23624bef87628b6bdfa73","after":"139880f7cb02691b09ff33851d22551bfac0341d","ref":"refs/heads/master","pushedAt":"2023-05-24T04:43:28.422Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge branch 'release-3.x'","shortMessageHtmlLink":"Merge branch 'release-3.x'"}},{"before":"fdf3d99451fe405ca83e7cd867598bdac4e0cebf","after":"7c3704ce15980ef58ef23624bef87628b6bdfa73","ref":"refs/heads/master","pushedAt":"2023-05-04T03:00:12.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge tag 'release-3.2'","shortMessageHtmlLink":"Merge tag 'release-3.2'"}},{"before":"50190ffff892401bc5f05f0afa3f406365af258b","after":"7424de7bac07cb741130d28a006d057d03b528f5","ref":"refs/heads/release-3.x","pushedAt":"2023-05-04T03:00:03.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Bump to 3.2.1 dev.","shortMessageHtmlLink":"Bump to 3.2.1 dev."}},{"before":"9efa0de4759cc67c132b9feab79a129d47ae968d","after":"50190ffff892401bc5f05f0afa3f406365af258b","ref":"refs/heads/release-3.x","pushedAt":"2023-05-04T02:33:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add release notes for Review Bot 3.2.\n\nThis is a small release that adds support for Review Board 5 API tokens\nin Secret Scanning, and fixes some compatibility issues with Shellcheck\non Python 3, with PMD, and with Review Board 5.\n\nTesting Done:\nBuilt the docs. Checked for build errors, spelling errors, and bad links.\n\nReviewed at https://reviews.reviewboard.org/r/12959/","shortMessageHtmlLink":"Add release notes for Review Bot 3.2."}},{"before":"a3df27ac7a9981d7147eb56c46adc76db2905b71","after":"fdf3d99451fe405ca83e7cd867598bdac4e0cebf","ref":"refs/heads/master","pushedAt":"2023-04-26T09:22:59.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge branch 'release-3.x'","shortMessageHtmlLink":"Merge branch 'release-3.x'"}},{"before":"37347fed5b56e1bd373f437e808a96dcb6c85ef9","after":"9efa0de4759cc67c132b9feab79a129d47ae968d","ref":"refs/heads/release-3.x","pushedAt":"2023-04-26T09:22:42.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Cap the maximum number of lines for a comment to 10.\n\nSome tools include a pretty wide range of lines when reporting a\ncomment. PMD, for instance, will list the entire line range for a\nfunction or a comment, which is excessive and not particularly useful.\n\nWe now cap comments to 10 lines. When capped, the total line range is\nshown in the comment, giving people enough context to see the entire set\nof lines for the reported issue.\n\nTesting Done:\nUnit tests pass.\n\nReviewed at https://reviews.reviewboard.org/r/12986/","shortMessageHtmlLink":"Cap the maximum number of lines for a comment to 10."}},{"before":"9d5173e81709172faa07a47fc56d733eab443be2","after":"37347fed5b56e1bd373f437e808a96dcb6c85ef9","ref":"refs/heads/release-3.x","pushedAt":"2023-04-17T23:56:32.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix a string type issue in ShellCheck and generally in unit tests.\n\nIn production on Python 3, ShellCheck would fail due to a string type\nissue when trying to build replacement strings. This was missed in unit\ntests due to an assumption being made that byte strings are appropriate\nfor diff content in \"diff data\" result from the API, when in fact those\nmust be Unicode strings, since the result is JSON (and encoding is\nhandled on the Review Board side).\n\nAddressing this required fixing up the mismatch in the ShellCheck code,\nand also updating the unit test helpers `run_tool_execute()` and\n`run_get_can_handle_file()` to convert any sample bytestring content to\nUnicode when building up a diff data payload.\n\nTesting Done:\nUnit tests pass on all supported versions of Python.\n\nVerified the ShellCheck fix with a customer.\n\nReviewed at https://reviews.reviewboard.org/r/12891/","shortMessageHtmlLink":"Fix a string type issue in ShellCheck and generally in unit tests."}},{"before":"f8de550b3ad7e947569ef2a408319c904e56df47","after":"a3df27ac7a9981d7147eb56c46adc76db2905b71","ref":"refs/heads/master","pushedAt":"2023-03-23T17:29:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix link to ShellCheck doc.\n\nREADME.rst has links to the documentation for all the different tools,\nbut the one for shellcheck had a copy/pasteo and was linking to the docs\nfor rustfmt.\n\nReviewed at https://reviews.reviewboard.org/r/12883/","shortMessageHtmlLink":"Fix link to ShellCheck doc."}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEMnwcnAA","startCursor":null,"endCursor":null}},"title":"Activity ยท reviewboard/ReviewBot"}