Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SvelteKit as a dependency #70

Closed
hobbes7878 opened this issue Jul 27, 2022 · 1 comment
Closed

Remove SvelteKit as a dependency #70

hobbes7878 opened this issue Jul 27, 2022 · 1 comment

Comments

@hobbes7878
Copy link
Member

Contingent on undertaking #69, we may want to make this a Svelte-only library.

Non-SvelteKit projects have problems with SvelteKit stores like $app/... and this library.

There are cases like the current SREPs Vite-based rig that don't use SvelteKit and there may be more in the future for slimmed down, single-page rigs. (Thinking our current homepage, which uses sapper now and may continue to need something that can compile down to a legacy bundle.)

Main breaking change would be that users will need to construct paths, e.g. with $assets store, before passing them into components like SEO.

@hobbes7878
Copy link
Member Author

Noting #72 as a good example of not relying on SvelteKit deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant