Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zotero 7: only citekey display in the item detail box remaining #2522

Open
26 of 27 tasks
jangid19 opened this issue May 22, 2023 · 366 comments
Open
26 of 27 tasks

Zotero 7: only citekey display in the item detail box remaining #2522

jangid19 opened this issue May 22, 2023 · 366 comments

Comments

@jangid19
Copy link

jangid19 commented May 22, 2023

The builds dropped here are release-ready for Zotero 6. Anything that does not work as expected in Zotero 6 will get priority to fix. For Zotero 7, 7.0.0-beta.26 is the minimum required version.

Open issues:

  • citekey display/edit field awaits API from Zotero (#)
  • settings screen is jacked up
  • auto-export is not triggered when the citekey is edited #
  • export screen errors out #
  • prefs screen has rendering issues on beta 26
  • BBT sentence-case for item titles Zotero sentence-case will be replaced by BBT sentence-case in Zotero 7 (#)
  • translator init takes insanely long. Nothing much I can do about it (#), but maybe I can just let that run in the background.
  • export options are not translated
  • disable-enable does not work
  • debug log needs to be resurrected -- again!
  • Top-level <wizard>…</wizard><window><wizard>…</wizard></window> and dialog button/event changes
  • all events routed through event-emitter
  • prefs screen needs to be resurrected
  • replace/inject window, remove document
  • item pane is not editable
  • Zotero 6 on MacOS: close and reopen of main pane works (but you can't select the citation key column after reopen, and there's no fix for this)
  • Zotero 7 on MacOS: citation key in the item-list column picker no longer works in Z7.
  • citekey in itempane focuses item type
  • update https://github.com/retorquere/zotero-debug-log for Z7
  • reinstall does not work
  • nsIIdleServicensIUserIdleService
  • XUL textbox → HTML <input type="text">
  • <label><label><html:h2> within <groupbox>
  • tooltiptexttitle — works automatically in existing windows; in new windows, requires a XUL <tooltip id="html-tooltip"> element and a tooltip="html-tooltip" attribute on the <window> (example)
  • prefs: quick-copy doesn't switch details screen
  • Top-level <dialog>…</dialog><window><dialog>…</dialog></window> and dialog button/event changes
  • createElement()/createElementNS()createXULElement() for remaining XUL elements (example)

Reference: Zotero 7 for developers

@tdegeus
Copy link

tdegeus commented May 27, 2023

Is there a timeframe?

@retorquere
Copy link
Owner

No. I'm actively working on it, and I keep thinking I'm close and then hitting another problem. It could be days, weeks or months.

@tdegeus
Copy link

tdegeus commented May 27, 2023

... Thanks for your hard work!

@redleafnew
Copy link

Will the plugin Zotero Debug Bridge be updated to be compatible with zotero v7?

@retorquere
Copy link
Owner

I've uploaded the new version, 6.7.79 should work with 7.

@retorquere
Copy link
Owner

No. I'm actively working on it, and I keep thinking I'm close and then hitting another problem. It could be days, weeks or months.

In a bit of good news, I'm one failing test away from getting BBT to bootstrapped, which is the most important hurdle.

@redleafnew
Copy link

I've uploaded the new version, 6.7.79 should work with 7.

Thanks. However, it prompts me:

The add-on "C:\Users\hmy\Desktop\debug-bridge-6.7.79.emile.limonia.xpi" could not be installed. It may be incompatible with this version of Zotero.

image

image

@chickymonkeys
Copy link

Same here, unfortunately. Running Zotero 7.0.0-beta.7+7c902d40a on Apple Silicon.

@retorquere
Copy link
Owner

retorquere commented May 29, 2023 via email

@retorquere
Copy link
Owner

New version is up, same version number though.

@redleafnew
Copy link

Download again, and still cannot be installed.

@retorquere
Copy link
Owner

I started the wrong version. I can replicate the install problem. Looking into it.

@retorquere
Copy link
Owner

New version installs on 7

@redleafnew
Copy link

Now it installs on v7

@retorquere
Copy link
Owner

I've asked on zotero-dev. The zotero-style plugin uses the zotero plugin toolkit, so I can't just copy what they've done.

@retorquere
Copy link
Owner

And apparently what they do breaks keyboard navigation, so they're advising to wait on the Zotero-provided API.

@retorquere
Copy link
Owner

Beta 70 breaks BBT, the work for that is tracked on #2829

@jrennstich
Copy link

Thanks for the update, I just was about to post a report. Thanks for all your great work on this!

@retorquere
Copy link
Owner

I'm dropping a new version that has citation key display in an item section. Not ideal but it'll have to do until the item details pane allows adding fields. It's janky, UI-wise, but functional.

@mjthoraval
Copy link

mjthoraval commented Apr 29, 2024

Thank you very much!

Could it be moved to the top of the Item Pane, in a fixed position that does not scroll with the rest of the Item Pane (maybe optional)?
The Preview plugin for example has done that (but it seems to slow down significantly the navigation between items): https://github.com/dcartertod/zotero-plugins
image
(I am not sure how it would decide which one to put on top if both plugins are active.)

Can the text "Citation Key" appear as the section title?
image
If the section is collapsed, it appears as empty:
image
Maybe the collapsed version could do the same as the abstract, showing the citation key in the same line?
image

But maybe no need to spend too much time on this if it is only temporary.

@retorquere
Copy link
Owner

Could it be moved to the top of the Item Pane, in a fixed position that does not scroll with the rest of the Item Pane (maybe optional)?

The Zotero crew consistently says "API for this is coming. Please wait". I tried previously to put stuff there and it was incredibly janky.

Can the text "Citation Key" appear as the section title? ... If the section is collapsed, it appears as empty:

I'll see if I can get that to work. I've followed their instruction but the text remains blank.

Maybe the collapsed version could do the same as the abstract, showing the citation key in the same line? ... But maybe no need to spend too much time on this if it is only temporary.

That's not in the Zotero API so they're probably watching the DOM. I'm just going to wait for the real API on this one.

@dstark
Copy link

dstark commented May 10, 2024

@retorquere, thanks so much for getting things back working to this extent! In Better BibTex 6.7.186 and Zotero 7.0.0-beta.77, there are certain circumstances where the citation key section displays the incorrect key. I haven't entirely sorted out when it happens, but it seems to mainly be when I've

  1. done a search and
  2. have updated something that requires the key to be revised.

In these circumstances, the old key displays (but isn't copyable) if the key section is collapsed and another random key (but copyable) if the section is expanded as in the examples below. I have to select some other item and then return to the original item for the correct updated key to display and be copyable.

image
image
image

@retorquere
Copy link
Owner

I haven't been able to reproduce it yet. A new build will drop here soon which will (pretty obnoxiously) show what's happening under the hood. It will pop up two notifications for every time you click an item (item display); remember the ID it showed when you clicked the item of interested, reproduce the problem, and you should see a notification with citekey refresh. I need the text in that notification. Each notification stays up 8 seconds.

Copy link

🤖 this is your friendly neighborhood build bot announcing test build 6.7.192.2522.6245 ("show citekey pane info")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.192.2522.6245, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

@dstark
Copy link

dstark commented May 17, 2024

I haven't been able to reproduce it yet. A new build will drop here soon which will (pretty obnoxiously) show what's happening under the hood. It will pop up two notifications for every time you click an item (item display); remember the ID it showed when you clicked the item of interested, reproduce the problem, and you should see a notification with citekey refresh. I need the text in that notification. Each notification stays up 8 seconds.

@retorquere, thanks so much. I have v6.7.193 installed, but I'm not seeing popups when I select items in Zotero 7.0.0-beta.78+5be5ca941.

@jryans
Copy link

jryans commented May 17, 2024

I used to see the same incorrect cite key issue as well, but it seems to have gone away with the latest add-on and Zotero versions.

@retorquere
Copy link
Owner

Oh maybe it was just a zotero bug. beta gonna beta.

@jryans
Copy link

jryans commented May 18, 2024

Ah actually, I saw the city key issue just now (with Zotero 7.0.0-beta.78+5be5ca941, BBT 6.7.196) when adding a website item via the connector, but didn't have the special build of this add-on installed at the time... 😅 I'll install it now so I can catch the issue next time.

@jryans
Copy link

jryans commented May 18, 2024

Okay, I believe I can reproduce the cite key issue reliably now with BBT debug build 6.7.192.2522.6245.

STR:

  1. Open several PDF tabs in Zotero (I have 4 open at the moment)
  2. Go to https://pola.rs/, save this site via the connector
  3. The parent item is created, and initially the correct cite key is shown
  4. A few seconds later, the web site attachment is added, and around then the wrong cite key appears

It's hard to relay the content of all of the BBT debug build notifications, as they are a lot of the flashing on screen. It looks like when the website attachment is added, BBT seems to think Zotero somehow cycled through all of the open PDF tabs as well. The newly added item ends up displaying the cite key for the 3rd open PDF tab in my case.

(Let me know if I should move this to a separate issue.)

@retorquere
Copy link
Owner

Ah yes, please open a new issue for this. I think we can do further diagnosis without all the boxes popping up -- if you open an issue I'll create a debug build that adds the required logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests