Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resguar var to const/let does not work all the times #757

Open
aminya opened this issue Oct 31, 2020 · 0 comments
Open

Resguar var to const/let does not work all the times #757

aminya opened this issue Oct 31, 2020 · 0 comments

Comments

@aminya
Copy link

aminya commented Oct 31, 2020 •
edited

Here is the example:
https://github.com/aminya/ScarletsFrame/commits/es6

See convert the rest using jscodeshift commit. I had to use jscodeshift to transform the rest:
aminya/ScarletsFrame@6839939
eventualbuddha referenced this issue in aminya/ScarletsFrame Nov 30, 2020
@aminya
convert the rest using jscodeshift
6839939 
npm install -g jscodeshift
git clone https://github.com/cpojer/js-codemod.git
jscodeshift -t <codemod-script> <file>

jscodeshift -t js-codemod/transforms/no-vars.js path_to_scarlets
eventualbuddha added a commit that referenced this issue Nov 30, 2020
@eventualbuddha
fix: do not allow block scoping in single-statement context
404aaf8 
Refs #757 and aminya/ScarletsFrame@6839939#r44671450.
@eventualbuddha eventualbuddha mentioned this issue Nov 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aminya