Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client request extensions don't throw #1692

Closed
alexeyzimarev opened this issue Jan 11, 2022 · 14 comments
Closed

Client request extensions don't throw #1692

alexeyzimarev opened this issue Jan 11, 2022 · 14 comments
Labels

Comments

@alexeyzimarev
Copy link
Member

Extensions like GetAsync or PostAsync should throw if the request wasn't successful.

However, it doesn't happen. The reason seems to be that the RestResponse instance gets the correct status (error), but doesn't get any exception set because of that. And, ThrowIfError only checks the exception, ignoring the status.

@alexeyzimarev
Copy link
Member Author

Released in 107.0.3

@m1dst
Copy link

m1dst commented Mar 15, 2022

The issue seems to be present in DownloadStreamAsync in v107.3.0

@alexeyzimarev alexeyzimarev reopened this Mar 25, 2022
@stale
Copy link

stale bot commented Apr 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 25, 2022
@repo-ranger
Copy link

repo-ranger bot commented Apr 25, 2022

⚠️ This issue has been marked wontfix and will be closed in 3 days

@m1dst
Copy link

m1dst commented Apr 25, 2022

Shouldn't be closed...

@stale stale bot removed the wontfix label Apr 25, 2022
@stale
Copy link

stale bot commented Jun 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@m1dst
Copy link

m1dst commented Jun 13, 2022

Shouldn't be closed and should be fixed.

@alexeyzimarev
Copy link
Member Author

The issue is quite trivial to fix, I am wondering why no one opens a PR to get rid of this issue.

@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 13, 2022
@repo-ranger
Copy link

repo-ranger bot commented Aug 13, 2022

⚠️ This issue has been marked wontfix and will be closed in 3 days

@repo-ranger repo-ranger bot closed this as completed Aug 16, 2022
@m1dst
Copy link

m1dst commented Oct 9, 2023

Don't think this ever got fixed.

@alexeyzimarev
Copy link
Member Author

It wasn't, but who supposes to fix it? I see you @m1dst commented quite a lot on this, have you considered spending 20 min of your time fixing it?

@m1dst
Copy link

m1dst commented Oct 9, 2023

I see there is a PR that is open which is related to this. #2128

@alexeyzimarev
Copy link
Member Author

They weren't linked, I am checking with the PR author if it addresses this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants