ToCamelCase extension works wrong for ending Id

[lekrus]

Expected Behavior

"AgreementId".ToCamelCase(CultureInfo.InvariantCulture).Should().Be("agreementId");

Actual Behavior

in 106.10.1 that works as expected
in 106.11.4 that returns "agreementid", so CamelCaseJsonSerializerStrategy works incorrectly

[deburau]

This is a big problem for me, too. Now I have to add DeserializeAs attributes to get things working again.

I propose to add the following tests to the ToPascalCase test in StringExtensionsTests.cs:

TestCase("thisIsAnotherTest", true, "ThisIsAnotherTest"), TestCase("thisIsAnotherTest", false, "Thisisanothertest")

and fixing ToCamelCase.

[liquidboy]

ive hit something similar to this too ...

pre 106.11.2 (working ToCamelCase in a strategy)

post 106.11.2+ (broken ToCamelCase, all properties are lowercase now)

doing as @deburau suggests and adding a DeserializeAs attribute everywhere is not feasible ..

Looking at the code changes for the StringExtensions, and i believe this is where the logic changed that is causing this issue.. I.e. it is now doing a ToLower aggressively, where as before (on the left) it was only doing it if the "rest of the word was uppercase"