Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking with ruby 3.2.0 #775

Closed
olafura opened this issue Jan 17, 2023 · 5 comments
Closed

Breaking with ruby 3.2.0 #775

olafura opened this issue Jan 17, 2023 · 5 comments

Comments

@olafura
Copy link

olafura commented Jan 17, 2023

Ruby seems to have changed the argument behavior which causes 120 failures in the test suite.
@olafura
Copy link
Author

olafura commented Jan 17, 2023

This is the first breaking change:
ruby/ruby@752c3da

@suwyn
Copy link

suwyn commented Jan 17, 2023

Appears the issue is upstream in Faraday.

Test pass with Faraday = 1.10 or >= 2.0.1

The version can be specified by setting the env var FARADAY_VERSION before bundle installing, which is what we did.

@timrogers
Copy link
Collaborator

I've created a PR with an upstream fix to Faraday: lostisland/faraday#1483. As @suwyn says, this issue only seems to affect Faraday v1.x.

@timrogers
Copy link
Collaborator

This is now fixed upstream in the latest Faraday v1.x version.

@olafura
Copy link
Author

olafura commented Jan 19, 2023

Thank you @timrogers that did the trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timrogers @olafura @suwyn