Use the request's Host header when setting RE's URI object. #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make a greater effort at capturing the actual hostname used by the client.
which means we need to read it from the Host header. Not sure why we didn't just copy what the other adapters did. Honestly, some of that should probably be abstracted _if_ reading from Host header is truly the right thing to do. I _think_ we shied away from this because it felt wrong to return 'unknown'. While that still feels wrong, I'm not sure what is a better option, so copying. I briefly thought about returning the IP address, which is what was happening before this effort to _not_ return the IP address!
from the request. We discussed 'asserting' here. Maybe that is the best way. I just haven't seen anyone do that in quite a while.
https://issues.redhat.com/browse/RESTEASY-3261 Signed-off-by: James R. Perkins <jperkins@redhat.com>
crankydillo
reviewed
Dec 13, 2022
| @@ -95,7 +95,7 @@ public void testCannotDetermineHost() { | |||
| try { | |||
| extractor.extract(req, "/contextPath"); | |||
| fail("Inability to determine a host address should have thrown an IllegalArgumentException."); | |||
| } catch (final AssertionError ae) { | |||
| } catch (final IllegalArgumentException ignore) { | |||
There was a problem hiding this comment.
Ugh, this was an accidental push:(
There was a problem hiding this comment.
No worries, I got the test working at least. 5.0.5.Final has been released too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RESTEASY-3261
Replaces #3296 with one extra commit.
Upstream #3360