Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why is coverage 0% for some models? (eg: subdomain) #830

Closed
donrestarone opened this issue Jun 27, 2022 · 2 comments · Fixed by #929 or #933
Closed

why is coverage 0% for some models? (eg: subdomain) #830

donrestarone opened this issue Jun 27, 2022 · 2 comments · Fixed by #929 or #933
Assignees
@alis-khadka
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@donrestarone
Copy link
Contributor

Describe the bug

we expect to see more than 0% coverage in models like subdomain

To Reproduce

Run CI and download the coverage report.

Expected behavior

We have tests for these models (eg: test/models/subdomain_test.rb)

Screenshots
Screen Shot 2022-06-27 at 8 11 13 AM
Screen Shot 2022-06-27 at 8 11 01 AM
@donrestarone donrestarone added the bug Something isn't working label Jun 27, 2022
@donrestarone
Copy link
Contributor Author

@Pralish is in discussions with the community on the apartment repo: influitive/apartment#220

PS @Pralish -- I believe we are using ros/apartment (https://github.com/rails-on-services/apartment) there may be changes on that repo that may have introduced this quirk

CC @alis-khadka

@donrestarone donrestarone added the good first issue Good for newcomers label Jul 7, 2022
@donrestarone
Copy link
Contributor Author

new research:

  1. Models in subfolders are reporting 0% coverage  simplecov-ruby/simplecov#671
  2. add minimum coverage validation: https://stackoverflow.com/questions/39747715/make-travis-fail-if-the-coverage-is-not-above-a-threshold-ruby
  3. https://stackoverflow.com/posts/58702112/revisions

This was referenced Jul 15, 2022
Merged
Merged
donrestarone added a commit that referenced this issue Jul 17, 2022
@donrestarone
[bug fix] resolve test coverage of models reports 0% (#929) (#933)
01ad480 
#### resolves: #830 no deploy needed

* try starting simplecov at rails boot to see if model coverage works

* undo

* prevent spring from running in test mode

* remove comment in env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alis-khadka alis-khadka

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@alis-khadka @donrestarone