Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 Checklist #74

Open
10 of 18 tasks
yaauie opened this issue Dec 5, 2013 · 0 comments
Open
10 of 18 tasks

2.0 Checklist #74

yaauie opened this issue Dec 5, 2013 · 0 comments
Assignees

Comments

@yaauie
Copy link
Member

yaauie commented Dec 5, 2013

The last 1.x version should support ALL of these changes when Redis::Namespace#initialize is called with deprecations: true OR the REDIS_NAMESPACE_DEPRECATIONS environment varible set, and should warn unless Redis::Namespace#initialize is called with warnings: false OR the REDIS_NAMESPACE_QUIET environment variable set.


  • deprecations pathway
    • deprecation path can be enabled with deprecations: true
    • deprecation path can be enabled with REDIS_NAMESPACE_DEPRECATIONS
    • deprecations: false is default
    • warnings pathway
    • warnings path can be disabled with warnings: false
    • warnings path can be disabled with REDIS_NAMESPACE_QUIET
    • warnings: true is default

  • Don't blindly proxy unknown commands. (Limit method_missing to only handle known commands #73)
  • Don't allow direct use of non-namespaced commands, but provide a straightforward way to run them when done intentionally, perhaps Redis::Namespace#without_namespace.flushdb
    • select
    • flushdb
    • flushall
    • shutdown ?
    • script ?
    • exec
  • Guarantee threadsafety for Redis::Namespace#pipelined and Redis::Namespace#multi (preferably without the use of mutexes, although we can use Redis#synchronize if we need to)
  • Avoid method_missing altogether, since we know the complete list of supported commands
@ghost ghost assigned yaauie Dec 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant