-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sadd_returns_boolean + sadd? method #217
Conversation
class << self | ||
attr_accessor :sadd_returns_boolean | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't needed, right? Can we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's needed, as it provides the way to set and read the sadd_returns_boolean
value. This is used by the Redis
gem to determine whether or not to display that deprecation message.
@iloveitaly Is there anything else you'd like me to look into for this PR? |
Thanks for the merge! Can we please get this included in a new gem release? |
Yes! I'll try to get to it this week. Ping me if it's not done!
… Message ID: ***@***.***>
|
@iloveitaly if you're busy I should be able to knock out a release today/tomorrow. |
Yeah I'm totally slammed so if you have time that would be great
…On Mon, Dec 19, 2022 at 9:09 AM Patrick Tulskie ***@***.***> wrote:
@iloveitaly <https://github.com/iloveitaly> if you're busy I should be
able to knock out a release today/tomorrow.
—
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABE2R36KDXMW5QVSJ4EX2DWOCCFJANCNFSM6AAAAAASLT2IOY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Release is mostly done but rubygems is kicking me out. I'll push up the gem once @iloveitaly has a chance to take a look. |
I think I fixed it! Let me know if that doesn't work.
Message ID: ***@***.***>
… |
Thanks @iloveitaly @radar this is now in 1.10.0. Thanks for sorting this out! |
Fixes #216.