Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brpoplpush takes keyword arguments for timeout: 123 #204

Open
mhenrixon opened this issue Jul 29, 2022 · 2 comments
Open

brpoplpush takes keyword arguments for timeout: 123 #204

mhenrixon opened this issue Jul 29, 2022 · 2 comments

Comments

@mhenrixon
Copy link

mhenrixon commented Jul 29, 2022

mhenrixon/sidekiq-unique-jobs#730 (comment)

It seems that redis-namespace doesn't support kwargs that the redis-rb gem uses. For example for brpoplpush like described by @cgunther in mhenrixon/sidekiq-unique-jobs#730 (comment).

I can replicate it, and I'd prefer to avoid using a deprecated API (the integer as the second argument) if I can avoid it.

Perhaps you could look into supporting keyword arguments as the redis-rb gem does?

@mhenrixon
Copy link
Author

#104

@jpaas
Copy link

jpaas commented Sep 20, 2022

I'm getting a warning when using sidekiq for brpop too.

  redis.brpop("development:queue:searchkick", "development:queue:default", "development:queue:mailers", "development:queue:low", timeout: 2)(called from: /Users/jpaas/.rvm/gems/ruby-3.1.2@karma-backend/gems/redis-namespace-1.9.0/lib/redis/namespace.rb:479:in `call_with_namespace')

The super annoying thing is that sidekiq does a lot of brpops, so my console is just constantly filling with these warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants