You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We run all python snippts on our main ci as part of the snippet comparison tests (and yes we even run those for which there's nothing much to compare).
The problem with this is however, that due to uncompiled & weakly typed nature of Python we easily run into issues where code isn't adequately checked (even considering that we run pixi run py-lint which executes mypy checks).
A recent example of such a failure was #6342 which would have been caught by running snippets. Note that this can't be caught by mypy since mypy lacks the information needed for knowing the named parameter actually exists.
Snippets have a much better code coverage than our tests and I believe it's unrealistic that pixi run py-test will cover cases like the cited one (ideally it would, but it implies that pretty much everything is covered not only by snippets but also by tests).
The expectation is that running snippets on python only should be fairly fast (especially compared to rust & cpp snippets which take quite a while to compile collectively)
The text was updated successfully, but these errors were encountered:
We run all python snippts on our
main
ci as part of the snippet comparison tests (and yes we even run those for which there's nothing much to compare).The problem with this is however, that due to uncompiled & weakly typed nature of Python we easily run into issues where code isn't adequately checked (even considering that we run
pixi run py-lint
which executes mypy checks).A recent example of such a failure was #6342 which would have been caught by running snippets. Note that this can't be caught by mypy since mypy lacks the information needed for knowing the named parameter actually exists.
Snippets have a much better code coverage than our tests and I believe it's unrealistic that
pixi run py-test
will cover cases like the cited one (ideally it would, but it implies that pretty much everything is covered not only by snippets but also by tests).The expectation is that running snippets on python only should be fairly fast (especially compared to rust & cpp snippets which take quite a while to compile collectively)
The text was updated successfully, but these errors were encountered: