Improve usage of monospace vs. proportional fonts for data display #6315
Labels
ui
concerns graphical user interface
Comments
8 tasks
abey79
added a commit
that referenced
this issue
May 14, 2024
### What - Follow up to #6291 - Fixes #6245 - Unblocks #4161 - Limitation #6315 This PR fixes the `UiLayout::List` implementations of `DataUi` such that they all fit on a single line and are deal with potentially narrow space (mostly via truncation). This PR unearthed quite some inconsistencies in how we're using monospace font for data. For now, `text_ui` (which uses monospace) has been renamed `data_label_for_ui_layout` to parallel the new `label_for_ui_layout` (which uses proportional). In the future (#6315), we must unify both with a better, flexible API that also allows mixed styles. TODO: - [x] blob: check with large binaries -> OK (could certainly be improved but it truncates correct 🤷🏻) - [x] tensor data: fix ui for `size(shape) > 3` - [x] range2d: improve label ### Screenshots <img width="488" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/e82c83c1-0f2b-4d64-9e76-71d28e3cba5c"> <img width="501" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/da811427-cad2-463e-8285-9ae096441fc5"> <img width="369" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/987af231-43c6-44e5-babb-52efdf110e30"> <img width="314" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/2a4174bf-8117-46e5-9734-5e3ac05dd209"> <img width="231" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/4fdc4e02-f6ff-43fc-8a68-163985ee0186"> <br/><br/> When truncated: <img width="228" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/cbfbbb79-df18-48e9-be82-0401feec9d93"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6297?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6297?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6297) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#6297 cleaned up the UI for components, but highlighted some inconsistencies with our usage of monospace vs. proportional font. That PR introduced two utility functions:
label_for_ui_layoutanddata_label_for_ui_layoutwhich unfortunately doesn't cover all the needs.Needs:
10deg, axis:[1, 0, 0]". This needs some helper over the complexegui::LayoutJobAPI.impl<egui::WdigetText>(e.g. for error displaylabel_for_ui_layout(ui, ui_layout, ctx.re_ui.error_text(err.to_string()));data_label_for_ui_layoutandlabel_for_ui_layoutThe text was updated successfully, but these errors were encountered: