Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests using GitHub Actions #334

Merged
merged 2 commits into from Oct 18, 2022

Conversation

pquentin
Copy link
Contributor

I think it's important to have a minimal green CI before making more substantial changes. The current limitations:

  • We're not running against multiple versions of requests - we'll have to decide how helpful it is anyway, given 2.1.0 and 2.2.1 are old now
  • We're not running the docs, docstring and readme jobs. (I tried docstrings but it failed -- just realized now that the failure was allowed in Travis!)
  • We're running tests on Python 2.7. I just checked and only 1% of users still use Python 2.7 so it's safe to drop but I think it should be done explicitly
  • Various tests don't work so I marked them as xfail. We'll need to fix the X509 tests before fixing the warnings

@achapkowski Can you please take a look?

@sigmavirus24 sigmavirus24 merged commit 8b17435 into requests:master Oct 18, 2022
@sigmavirus24
Copy link
Collaborator

LGTM

@pquentin pquentin deleted the github-actions-ci branch October 21, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants