Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails after 2021-11-27 #270

Closed
bmwiedemann opened this issue May 14, 2019 · 2 comments
Closed

Test fails after 2021-11-27 #270

bmwiedemann opened this issue May 14, 2019 · 2 comments

Comments

@bmwiedemann
Copy link

Error is maybe from tests/certs/test_cert.p12

E           ValueError: Client certificate expired: Not After: 2021-11-27 15:28:58Z Not Before: 2018-11-28 15:28:58Z

requests_toolbelt/adapters/x509.py:139: ValueError
________________________ TestX509Adapter.test_x509_pem _________________________

Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our python-requests-toolbelt package build.
See https://reproducible-builds.org/ for why this matters.

@bmwiedemann
Copy link
Author

Would be good to see this solved in the next 10 months.

@pquentin
Copy link
Contributor

pquentin commented Feb 7, 2023

This was fixed in #335 which was merged as part of #336. Thanks for the warning, sorry that we did not act on it in time.

@pquentin pquentin closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants