Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs more maintainers #385

Open
JonathanHuot opened this issue Sep 10, 2019 · 13 comments
Open

Needs more maintainers #385

JonathanHuot opened this issue Sep 10, 2019 · 13 comments

Comments

@JonathanHuot
Copy link
Contributor

JonathanHuot commented Sep 10, 2019

Related to the oauthlib's oauthlib/oauthlib#485 and oauthlib/oauthlib#678, the project requests-oauthlib requires a lot of attention.

The python community is actively using the project, thru downstream libraries (e.g. https://github.com/singingwolfboy/flask-dance amongst others) and/or directly (see screenshot below)
Untitled

@singingwolfboy is already doing a great job as much as he can, but it requires additional human-efforts to review/complete/merge the PR, handle the release, and reply to issues.

As being already active for oauthlib, I'm volunteer to be part of the requests-oauthlib community and help the project to keep the lights on. This is not only for maintenance but also needed for integrating the features that we have recently added into oauthlib (PKCE, OpenID Connect).

I hope also that this message will find some other contributors to accelerate the project activity.

@JonathanHuot
Copy link
Contributor Author

Any updates, beloved community of @requests-oauthlib ?

@singingwolfboy, @jtroussard, @jdufresne, @nateprewitt, @Lukasa ?
Would be great to have more hands to cope with the number of PRs and fix longstanding issues related to build/documentation.

@jtroussard
Copy link
Contributor

I'm planning to carve out a few hours this weekend to try and verify some of the more recent PR's and leave some comments for others to review.

Hope everyone is doing alright and staying healthy.

@JonathanHuot
Copy link
Contributor Author

Hi @jtroussard, thanks for your immediate effort, however I was thinking to fix the problem on long term.
I think it helps if someone like you participate more, however we know that everyone has limited time to spend.

In order to accelerate and remove the bottleneck in long term, I was thinking of a series of changes (based on my experience for the oauthlib project, #references in the initial description):

  1. add branch restriction on "master" with GitHub settings as below:
  • Require pull request reviews before merging
  • Require status checks to pass before merging
  1. add more people to the list of "write" access (if you don't get it, I'm interested to have write access). Anyway, a PR will be protected and cannot be merged before a valid review from a peer has been done.

@ThomasHagebols
Copy link

I would also be interested to help out here

@JonathanHuot
Copy link
Contributor Author

Hi @jtroussard, any help on the ownership / extend of the write-access member's list for requests-oauthlib ?

@JonathanHuot
Copy link
Contributor Author

Hi @jtroussard, @singingwolfboy , any possible actions to extend the write permissions for this project ? i.e. ability to review & merge, change simple settings of projects.

Unfortunately, last commit is 2y old and issues/MR are created monthly showing a still active & important usage of this project.

I'm still volunteer of doing my part and trying to clean some of the sections as strictly required.

@JonathanHuot
Copy link
Contributor Author

Hi community,

I am happy to have the write access of the project now and proud to be part of this.

I will try to keep this thread open for a couple of months to see if we can build a community based on motivation of others.

@jtroussard
Copy link
Contributor

jtroussard commented Nov 8, 2021

Sorry for the delayed response - in the middle of an interstate move and new employment.

In terms of granting write access, doesn't look like I can do much. I believe when I was granted it, it was @singingwolfboy who reached out to those with ownership access to make this happen. I'll cc those involved.

cc: @nateprewitt @Lukasa @idan

@jtroussard
Copy link
Contributor

@JonathanHuot Hope this helps with getting you that access. With regards to direct contribution, I have plans to invest some more time into the project as soon as I am resettled. I'll try to squeeze in some time here and there.

@jtroussard
Copy link
Contributor

@JonathanHuot I am willing to tag team a clean-up/docs/pipeline effort to push an official release in the future

@JonathanHuot
Copy link
Contributor Author

Hi @jtroussard , that's great, I have cleanup the docs pipeline and tox parts; I saw you started to have a look on Github Actions, that's great!

On a side note, I asked admins to enable the following project settings :

"Master" branch restriction:

  • Require a pull request before merging
  • Require status checks to pass before merging
  • Require branches to be up to date before merging
  • Require conversation resolution before merging

@JonathanHuot
Copy link
Contributor Author

nateprewitt told me offline that the changes are now active in the project. We can start playing around the pipeline on the branches, and see if checks are there !

@jtroussard
Copy link
Contributor

Hi @jtroussard , that's great, I have cleanup the docs pipeline and tox parts; I saw you started to have a look on Github Actions, that's great!

On a side note, I asked admins to enable the following project settings :

"Master" branch restriction:

  • Require a pull request before merging (confirmed)
  • Require status checks to pass before merging
  • Require branches to be up to date before merging
  • Require conversation resolution before merging (confirmed)

What is left to update? Reconfigured Travis/Coveralls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants