Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of hawk and qs to latest version #2751

Merged
merged 1 commit into from Aug 24, 2017

Conversation

Olivier-Moreau
Copy link
Contributor

@Olivier-Moreau Olivier-Moreau commented Aug 24, 2017

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

I updated hawk from 3.1.3 to 6.0.2 (still a ~ for version managing)
I updated qs too from 6.4.0 to 6.5.0 (kept the ~)

npm test ran without error. I didn't add a test since I only changed version.

@mikeal mikeal merged commit 479143d into request:master Aug 24, 2017
@Olivier-Moreau Olivier-Moreau deleted the update-packets branch August 25, 2017 07:14
gtmanfred added a commit to gtmanfred/salt that referenced this pull request Aug 25, 2017
This fails on centos 6 because its node is too old to support the version of
hawk bumped here request/request#2751, we can still
test the functionality.  This will pull from github, and install a specific tag
version, and we still do the uninstall using the github path.

This should be more stable.
@louisbuchbinder
Copy link

louisbuchbinder commented Sep 19, 2017

@Olivier-Moreau @mikeal

Hi sorry to be a pain, but this change broke semver minor version update. This is a breaking change as the new hoek uses const instead of var

const Hoek = require('hoek');
^^^^^
SyntaxError: Use of const in strict mode.```

@lostip
Copy link

lostip commented Sep 20, 2017

@louisbuchbinder the package.json has the engine properly set:

   "engines": {
     "node": ">= 4"
   },

but npm has a very unfortunate default, where this is interpreted as a suggestion sort of, unless you use the engine-strict flag.
See: https://docs.npmjs.com/files/package.json#engines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants