Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test-timing keepAlive test #2590

Merged
merged 2 commits into from Mar 16, 2017
Merged

Adds test-timing keepAlive test #2590

merged 2 commits into from Mar 16, 2017

Conversation

nicjansma
Copy link
Contributor

PR Checklist:

PR Description

Adds an additional KeepAlive test for #2566, increasing test coverage.

Copy link
Contributor

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, thanks for following up.

Why the two, nested requests? Can you split this into two tests, or add a comment to explain the reason for it?

@nicjansma
Copy link
Contributor Author

@FredKSchott This new test is specifically testing keep-alive, so we need to have two requests to validate. I've added a comment!

@FredKSchott
Copy link
Contributor

Nice, thanks again! Merging now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants