Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to safe-buffer for improved security. #2574

Merged
merged 1 commit into from Mar 4, 2017
Merged

Conversation

mikeal
Copy link
Member

@mikeal mikeal commented Mar 4, 2017

Tests have run and passed locally but I'm curious to see what CI says because I haven't tested against older versions of Node.js yet.

I ended up having to push a quick release of tunnel-agent to cover this potential vulnerability fully. There are no tests for tunnel-agent so that only way to get any coverage was to push a release and then pull that new release into this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant