Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__ CERT_HAS_EXPIRED in https://github.com/request/request #3024

Closed
odykyi opened this issue Aug 31, 2018 · 6 comments
Closed

__ CERT_HAS_EXPIRED in https://github.com/request/request #3024

odykyi opened this issue Aug 31, 2018 · 6 comments

Comments

@odykyi
Copy link
Contributor

odykyi commented Aug 31, 2018

Every pull request build failed in travis
See err:


    operator: equal
    expected: |-
      null
    actual: |-
      { [Error: certificate has expired] code: 'CERT_HAS_EXPIRED' }
    at: Request._callback (/home/travis/build/request/request/tests/test-https.js:43:11)
    stack: |-
      Error: certificate has expired
          at TLSSocket.onConnectSecure (_tls_wrap.js:1047:34)
          at TLSSocket.emit (events.js:182:13)
          at TLSSocket._finishInit (_tls_wrap.js:629:8)

Linked PR: https://github.com/request/request/pull/3023/files
You can see changes not break build, but build failed because CERT_HAS_EXPIRED

@codenirvana
Copy link

server.crt used in HTTPS Tests is valid from July 8, 2018 to August 7, 2018.

Similar to older issues: #2955, #2976

Any particular reason to have test certificates valid only for 1 month? 😅

@mikeal mikeal closed this as completed Oct 4, 2018
@mikeal mikeal reopened this Oct 4, 2018
@adnan-alhomssi
Copy link

any updates ? any build (including the new PR am working on) will keep failing till this is fixed.

@odykyi
Copy link
Contributor Author

odykyi commented Oct 18, 2018

@adnan-alhomssi @mikeal who can fix this issue?

@odykyi odykyi changed the title CERT_HAS_EXPIRED in https://github.com/request/request __ CERT_HAS_EXPIRED in https://github.com/request/request Oct 18, 2018
@reconbot reconbot mentioned this issue Nov 22, 2018
1 task
@reconbot
Copy link
Contributor

Thank you @odykyi for staying on this issue. It's now fixed!

I've added instructions on how anyone can fix this in the future in #3062

@sushilarora
Copy link

sushilarora commented Jun 1, 2020

Hi @reconbot
I am facing the same issue again.
I was requesting JSON File using the request module and it was working fine till 2 days back but today I am getting "CERT HAS EXPIRED" issue. Is this possible that this issue occurred again Or is it something at my end?

@rahmanroman
Copy link

@sushilarora
strictSSL: false option helps me as a quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants