Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to simplify & update convenience methods #2641

Merged
merged 1 commit into from Apr 18, 2017

Conversation

FredKSchott
Copy link
Contributor

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: N/A

PR Description

I realized that there is a README section on the request convenience methods after merging #2541, so I made a quick update to that section to simplify it (no need for it to be so long) and update it (add the newest request.options() method).

/cc @jamesseanwright

@FredKSchott FredKSchott merged commit e999203 into master Apr 18, 2017
@FredKSchott FredKSchott deleted the FredKSchott-patch-1 branch April 18, 2017 23:25
@jamesseanwright
Copy link
Contributor

Oops, sorry I missed this! Thanks for the update.

@tsuzfr
Copy link

tsuzfr commented Jul 13, 2017

Thanks for merging the update. However, v2.81.1 does not seem to be in the npm directory. The latest one is v2.81.0. Do you think we can update this?

@FredKSchott
Copy link
Contributor Author

That's intentional to differentiate between the version on npm & the version on github/master

@nylen
Copy link
Member

nylen commented Jul 14, 2017

The only times the .0 vs .1 thing has ever come up, it has been more confusing than helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants