Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lodash #25

Open
deleonio opened this issue Jun 12, 2020 · 5 comments
Open

remove lodash #25

deleonio opened this issue Jun 12, 2020 · 5 comments

Comments

@deleonio
Copy link

No description provided.

@s100
Copy link

s100 commented Jun 25, 2020

The priority of this task may be about to increase due to this prototype pollution vulnerability in lodash, which lodash's maintainers seem not to be acting on.

@Pomax
Copy link

Pomax commented Sep 4, 2022

gentle reminder that this issue exists, and is still an exceptionally good idea. Also because lodash is a huge dependency for the handful of (by now effectively covered by vanilla JS) functions that the code relies on.

@s100
Copy link

s100 commented Sep 5, 2022

@Pomax request-promise-core is used primarily by request-promise, request-promise-any, request-promise-bluebird and request-promise-native. All of those packages are heavily deprecated and have not been under active development for several years. So, I would be extremely surprised to see request-promise-core ever change again. I strongly recommend migrating away from request-promise-core - or whatever you use which uses request-promise-core internally - to something else.

(The prototype pollution vulnerability in lodash is long since fixed, at least.)

@Pomax
Copy link

Pomax commented Sep 5, 2022

I'd love to, but this wasn't because I'm using promise-core, but because a millions-of-installs-a-day package has it as a dependency of a dependency of a dependency. (request-promise is used by almost 10,000 other packages)

@s100
Copy link

s100 commented Sep 6, 2022

request-promise is deprecated and unmaintained, even for security fixes. As painful as it may be, migrating away from it is the only solution to your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants