Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: common labels for applications #1186

Open
MikaelSmith opened this issue Oct 23, 2020 · 5 comments
Open

Feature: common labels for applications #1186

MikaelSmith opened this issue Oct 23, 2020 · 5 comments

Comments

@MikaelSmith
Copy link
Contributor

KOTS applications use Kustomize under the hood. One feature that would be very useful to have from Kustomize when creating applications for KOTS is commonLabels. It allows me to remove a lot of redundant labeling and selectors.

I can think of two ways to implement this:

  • add a commonLabels property to the kots Application resource that gets passed through to the base kustomization
  • allow creating a kustomization.yaml in your application manifests that initializes the base kustomization. This allows using most of kustomize's features, although I don't have specific uses for others yet.
@markpundsack
Copy link
Contributor

@MikaelSmith Interesting idea. Can you elaborate on the problem and use case? What kinds of labels would you want to apply, where would you want them applied, what are you ultimately trying to achieve, etc.?

@MikaelSmith
Copy link
Contributor Author

We're primarily adding them to everything to identify all things common to our application. A app.kubernetes.io/part-of label (https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/). We might also add other labels or annotations, such as identifying the release version.

@markpundsack
Copy link
Contributor

Thanks, that helps.

@markpundsack
Copy link
Contributor

Tracking internally here: https://app.clubhouse.io/replicated/story/27657

I'm in favor of adding the base kustomization.yaml.

@MikaelSmith
Copy link
Contributor Author

We'd also like this to use with NetworkPolicy so we don't affect everything in a namespace. But maybe that's a bit of a fools errand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants