Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase client-go k8s config QPS and burst for better performance #3886

Open
DexterYan opened this issue Dec 21, 2022 · 1 comment
Open

Comments

@DexterYan
Copy link
Member

By checking the code under pkg/cli, we can see

k8sConfig := config.GetConfigOrDie()

so we are using the client-go of k8s.

In the GetConfigOrDie() function, we could find that it is using

func GetConfigWithContext(context string) (*rest.Config, error) {
	cfg, err := loadConfig(context)
	if err != nil {
		return nil, err
	}

	if cfg.QPS == 0.0 {
		cfg.QPS = 20.0
		cfg.Burst = 30.0
	}

	return cfg, nil
}

Which means we are set QPS 20 and Burst 30. For better performance, I would recommend to use QPS 100 and Burst 100, same as kots https://github.com/replicatedhq/kots/pull/3523/files

@camilamacedo86
Copy link
Contributor

@DexterYan,

Would be possible to make this suggestion via a shortcut and close this one? So that it get in the process.

Thank you for raising it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants