Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using alternative HTTP clients #29

Open
benswift opened this issue Feb 15, 2024 · 1 comment
Open

using alternative HTTP clients #29

benswift opened this issue Feb 15, 2024 · 1 comment

Comments

@benswift
Copy link

tl;dr are you open to a PR which replaces the HTTPoison dep with Req?

The "my app uses a different HTTP client to one of my deps, and leads to bloat" issue is obviously a tricky one. Andrea Leopardi has the best summary of the current state of play for Elixir HTTP clients.

In particular, httpoison is a bit old-school these days - many cool kids are using Req (my fav) or Tesla.

My specific question in this issue: is this lib using httpoison for a specific reason? (There used to be some multipart form-based reasons to use it over e.g. Req, although I don't think that's still the case.) The Leopardi blog post linked above says that other HTTP client libs have superseded httpoison these days. If not, are you open to a PR which replaces the HTTPoison dep with Req? Client API would remain the same; winners of this change would be those who are already using Req in their apps, and losers would be those who are currently using httppoison (in my estimation the former is a bigger group than the latter, although I don't have stats on that). Although no-one's code would break, the "victims of bloat" problem would just be re-distributed.

Anyway, sorry about the long issue - just wanted to check first before I did any work. If you don't want it that's fine too :)

@benswift
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant