Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gomod dependency updates type are now patch (where digest before) #29034

Closed
rarkins opened this issue May 13, 2024 Discussed in #29033 · 2 comments · Fixed by #29042
Closed

Gomod dependency updates type are now patch (where digest before) #29034

rarkins opened this issue May 13, 2024 Discussed in #29033 · 2 comments · Fixed by #29042
Assignees
Labels
manager:gomod Go Modules priority-2-high Bugs impacting wide number of users or very important features regression Issue about a regression bug, or the PR caused it type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 13, 2024

Discussed in #29033

Originally posted by aerialls May 13, 2024

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab with the latest Renovate version

Please tell us more about your question or problem

Hello,
Not sure this is a bug but I found a change of behavior introduced in 37.327.1 using the gomod manager. Updates from the module google.golang.org/genproto/googleapis/rpc are found of type patch as of before version 37.327.1, the type digest was returned.

A full working repository is available at https://github.com/aerialls/renovate-gomod. I've also attached in the README the log from both versions to highlight the change of updateType

Logs (if relevant)

37.327.0

Check the updateType.

DEBUG: Branch summary (repository=api-gateway/test)
       "cacheModified": undefined,
       "baseBranches": [{"branchName": "master", "sha": "d3b2a5c7e83004dc75ef21de93d6e95e618e15c4"}],
       "branches": [],
       "defaultBranch": "master",
       "inactiveBranches": ["renovate/google.golang.org-genproto-googleapis-rpc-digest"]
DEBUG: branches info extended (repository=api-gateway/test)
       "branchesInformation": [
         {
           "branchName": "renovate/google.golang.org-genproto-googleapis-rpc-digest",
           "prNo": null,
           "prTitle": "chore(deps): update google.golang.org/genproto/googleapis/rpc digest to 6275950",
           "result": "no-work",
           "upgrades": [
             {
               "datasource": "go",
               "depName": "google.golang.org/genproto/googleapis/rpc",
               "displayPending": "",
               "fixedVersion": "v0.0.0-20240506185236-b8a5c65736ae",
               "currentVersion": "v0.0.0-20240506185236-b8a5c65736ae",
               "currentValue": "v0.0.0-20240506185236-b8a5c65736ae",
               "currentDigest": "b8a5c65736ae",
               "newValue": "v0.0.0-20240506185236-b8a5c65736ae",
               "newDigest": "62759503f4344226051f4e24858a7517e45b4ae6",
               "packageFile": "go.mod",
               "updateType": "digest",
               "packageName": "google.golang.org/genproto/googleapis/rpc"
             }
           ]
         }
       ]

37.327.1

Check the updateType.

DEBUG: Branch summary (repository=api-gateway/test)
       "cacheModified": undefined,
       "baseBranches": [{"branchName": "master", "sha": "d3b2a5c7e83004dc75ef21de93d6e95e618e15c4"}],
       "branches": [],
       "defaultBranch": "master",
       "inactiveBranches": ["renovate/google.golang.org-genproto-googleapis-rpc-0.x"]
DEBUG: branches info extended (repository=api-gateway/test)
       "branchesInformation": [
         {
           "branchName": "renovate/google.golang.org-genproto-googleapis-rpc-0.x",
           "prNo": null,
           "prTitle": "chore(deps): update module google.golang.org/genproto/googleapis/rpc to v0.0.0-20240509183442-62759503f434",
           "result": "no-work",
           "upgrades": [
             {
               "datasource": "go",
               "depName": "google.golang.org/genproto/googleapis/rpc",
               "displayPending": "",
               "fixedVersion": "v0.0.0-20240506185236-b8a5c65736ae",
               "currentVersion": "v0.0.0-20240506185236-b8a5c65736ae",
               "currentValue": "v0.0.0-20240506185236-b8a5c65736ae",
               "currentDigest": "b8a5c65736ae",
               "newValue": "v0.0.0-20240509183442-62759503f434",
               "newVersion": "v0.0.0-20240509183442-62759503f434",
               "newDigest": "62759503f434",
               "packageFile": "go.mod",
               "updateType": "patch",
               "packageName": "google.golang.org/genproto/googleapis/rpc"
             }
           ]
         }
       ]
```</div>
@rarkins rarkins added type:bug Bug fix of existing functionality priority-2-high Bugs impacting wide number of users or very important features manager:gomod Go Modules regression Issue about a regression bug, or the PR caused it labels May 13, 2024
@zharinov
Copy link
Collaborator

if (!config.digestOneAndOnly || !res.updates.length) {
// digest update
res.updates.push({
updateType: 'digest',
newValue: config.currentValue,
});
}

  • It was introduced 6 years ago: 8597f16

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.368.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager:gomod Go Modules priority-2-high Bugs impacting wide number of users or very important features regression Issue about a regression bug, or the PR caused it type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants