Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenTelemetry] allow to overwrite provided Resource attributes #28986

Open
secustor opened this issue May 10, 2024 · 1 comment
Open

[OpenTelemetry] allow to overwrite provided Resource attributes #28986

secustor opened this issue May 10, 2024 · 1 comment
Labels
good first issue Suitable for new contributors priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@secustor
Copy link
Collaborator

secustor commented May 10, 2024

To allow users to overwrite our defined resource attributes, we should check if the following environment variables are defined.
If they are unset or empty, our variables should be set.

For the three attributes that would be:

Originally posted by @secustor in #28976 (reply in thread)

The code is located here:

[SemanticResourceAttributes.SERVICE_NAME]: 'renovate',
[SemanticResourceAttributes.SERVICE_NAMESPACE]: 'renovatebot.com',
[SemanticResourceAttributes.SERVICE_VERSION]: pkg.version,

@secustor secustor added type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people good first issue Suitable for new contributors labels May 10, 2024
@HonkingGoose
Copy link
Collaborator

There's a typo in the issue tile: attributres should be: attributes.

@secustor secustor changed the title [OpenTelemetry] allow to overwrite provided Resource attributres [OpenTelemetry] allow to overwrite provided Resource attributes May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Suitable for new contributors priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants