-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document sourceUrl and releaseTimestamp support in datasources #28947
Comments
In addition to the work above, please create any necessary GitHub issues to add releaseTimestamp or sourceUrl support for any particular datasources which are missing them but for which we think it should be possible. |
This sounds like the I don't know if you can make the |
In some cases, for eg. Which |
In that case, package |
sourceUrlSupport: 'package' | 'release' | 'none' | 'true' ?? |
Corrected to "package". i.e the sourceUrl is returned per package and we don't the concept of sourceUrl per-release |
What should be done when |
I'm not sure we use the timestamp for digests. I'd consider that support false if it's not per-release |
Describe the proposed change(s).
Extend
renovate/lib/modules/datasource/types.ts
Lines 111 to 114 in 5de7eee
To be like:
releaseTimestampSupport
should betrue
if the datasources looks for release.releaseTimestampsourceUrlSupport
should berelease
if the datasource supports returning them per-release (e.g. npm),package
if they can be returned but only per-package (e.g. cdnjs), ornone
if nosourceUrl
logic exists.The optional note fields should ideally be filled into clarify how the field is determined. e.g in both npm and cdnjs, it's from the
repository
value in the results. Can we possibly use types to make these note fields mandatory if their sibling field is set?The text was updated successfully, but these errors were encountered: