Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(self-hosted): mergeConfidenceEndpoint and mergeConfidenceDatasources #28880

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented May 6, 2024

Changes

Convert the RENOVATE_X_MERGE_CONFIDENCE_API_BASE_URL and RENOVATE_X_MERGE_CONFIDENCE_SUPPORTED_DATASOURCES to self hosted config options, mergeConfidenceEndpoint and mergeConfidenceDatasources respectively.

Context

Closes: #28718

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh changed the title convert merge-condifence env vars feat(self-hosted): mergeConfidenceApiBaseUrl and mergeConfidenceSupportedDatasources May 6, 2024
@rarkins
Copy link
Collaborator

rarkins commented May 7, 2024

@nabeelsaabna perhaps needs some rewriting while we're at it to clarify that it's only for Renovate EE?

@nabeelsaabna
Copy link
Contributor

@nabeelsaabna perhaps needs some rewriting while we're at it to clarify that it's only for Renovate EE?

Also usable by Remediate.

will the old env RENOVATE_X_MERGE_CONFIDENCE_API_BASE_URL be ignored now ?
If yes, Can we rename mergeConfidenceApiBaseUrl to mergeConfidenceEndpoint ?

@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented May 7, 2024

will the old env RENOVATE_X_MERGE_CONFIDENCE_API_BASE_URL be ignored now ?

If set, it will be migrated to RENOVATE_MERGE_CONFIDENCE_API_BASE_URL.

@rarkins
Copy link
Collaborator

rarkins commented May 7, 2024

Let's get the name right while we're doing this. If we have to do a more complicated renaming of the env then let's do it. @nabeelsaabna please decide which name(s) you'd like

@nabeelsaabna
Copy link
Contributor

mergeConfidenceEndpoint is the more readable name 👍

rarkins
rarkins previously approved these changes May 8, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
lib/config/options/index.ts Dismissed Show dismissed Hide dismissed
@RahulGautamSingh RahulGautamSingh changed the title feat(self-hosted): mergeConfidenceEndpoint and mergeConfidenceSupportedDatasources feat(self-hosted): mergeConfidenceEndpoint and mergeConfidenceDatasources May 14, 2024
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
docs/usage/self-hosted-configuration.md Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
@rarkins rarkins enabled auto-merge May 21, 2024 10:13
@HonkingGoose
Copy link
Collaborator

Some conversations need to be resolved before this can be auto-merged.

@rarkins rarkins added this pull request to the merge queue May 21, 2024
Merged via the queue into renovatebot:main with commit 044dc0f May 21, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.370.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert merge confidence experimental env to config options
7 participants