Replace as with satisfies keyword

[RahulGautamSingh]

Describe the proposed change(s).

Typescript recently got a new keyword satisfies. In a recent discussion on the Slack channel it was agreed upon to replace as with satisfies

There some detailed info this issue.

I am not sure if all instances of as need to be repalced. If they can be good, else I will list the reasons as I find them and
this issue will be used to track all related updates/changes on that topic.

[RahulGautamSingh]

renovate/lib/modules/manager/cocoapods/artifacts.spec.ts

Lines 115 to 117 in 3a58d23

	git.getRepoStatus.mockResolvedValueOnce({
	modified: [] as string[],
	} as StatusResult);

There are many tests where such assertions are used. I don't think we can use satisfies here. Will it be desirable to instead initialize a minimal mockObject that has all non-optional properties and use that instead:

const mockStatusResult: StatusResult = { ...haveAllStrictFields }

..

git.getRepoStatus.mockResolvedValueOnce(mockStatusResult);
git.getRepoStatus.mockResolvedValueOnce({ ...mockStatusResult, modified:['somefile']});

[viceice]

we should probably use our partial helper function there.

[HonkingGoose]

Do we need to update our developer best practice documentation ¹ to tell contributors/maintainers to use satisfies instead of as keyword?

Footnotes

1. https://github.com/renovatebot/renovate/blob/main/docs/development/best-practices.md ↩

[viceice]

yes please

[rarkins]

@RahulGautamSingh much work left here?

[RahulGautamSingh]

There are still some test files where we use any / never . Maybe 2 more PRs are needed.