Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR gets auto-merged with changed version in title, but not changed contents #12124

Closed
HonkingGoose opened this issue Oct 12, 2021 · 10 comments · Fixed by #14228
Closed

PR gets auto-merged with changed version in title, but not changed contents #12124

HonkingGoose opened this issue Oct 12, 2021 · 10 comments · Fixed by #14228
Assignees
Labels
priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality

Comments

@HonkingGoose
Copy link
Collaborator

How are you running Renovate?

WhiteSource Renovate hosted app on github.com

Please select which platform you are using if self-hosting.

github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Describe the bug

Our Dependency Dashboard 1 says:

##Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

  • chore(deps): update dependency yarn to v1.22.15

Sequence of events:

  1. Renovate opens PR for yarn v1.22.14 2
  2. Renovate updates PR title to v1.22.15
  3. Renovate automerges with PR title v1.22.15 but contents still at v1.22.14
  4. Dashboard gets stuck because it thinks update v1.22.15 is merged (it is, just with wrong file contents)

We still need to update to yarn v1.22.15 in our .devcontainer/Dockerfile file:

RUN install-tool yarn 1.22.14

Relevant debug logs

I don't have access to the logs on the renovatebot/renovate repository, sorry!

Have you created a minimal reproduction repository?

No reproduction repository

Footnotes

  1. https://github.com/renovatebot/renovate/issues/2958

  2. https://github.com/renovatebot/renovate/pull/12055

@HonkingGoose HonkingGoose added type:bug Bug fix of existing functionality status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Oct 12, 2021
@HonkingGoose HonkingGoose changed the title Dependency dashboard getting stuck PR gets auto-merged with changed version in title, but not changed contents Oct 12, 2021
@viceice
Copy link
Member

viceice commented Oct 12, 2021

@rarkins Not really sure what happened there 🤔

@rarkins
Copy link
Collaborator

rarkins commented Oct 12, 2021

The true bug is that the contents didn't change

@giannello
Copy link

giannello commented Oct 15, 2021

We are affected by the same problem. PR titles are updated, but no commit with the actual change is pushed.
Extract from the relevant logs

{"msg":"Using RE2 as regex engine","time":"2021-10-15T13:55:02.078Z","v":0}
{"msg":"Parsing configs","time":"2021-10-15T13:55:04.223Z","v":0}
{"msg":"Converting NPM_NPM_PKG_GITHUB_COM_TOKEN into a global host rule","time":"2021-10-15T13:55:04.236Z","v":0}
{"config":{"extends":["config:base"],"allowPostUpgradeCommandTemplating":true,"allowedPostUpgradeCommands":["^bash"],"binarySource":"docker","enabledManagers":["regex"],"regexManagers":[{"fileMatch":["(^|/)\\.pre-commit-config\\.yaml$"],"matchStrings":["repo: (?<depName>.{2,}?)\n\\s+rev: (?<currentDigest>.*?)\n"],"datasourceTemplate":"git-refs","versioningTemplate":"git"}],"packageRules":[{"matchPaths":[".pre-commit-config.yaml"],"matchUpdateTypes":["digest"],"labels":["renovate","renovate-pre-commit"],"prBodyTemplate":"{{{table}}}{{{notes}}}{{{changelogs}}}"}],"npmrc":"***********","labels":["renovate"],"timezone":"Europe/Berlin","hostRules":[{"matchHost":"eu.gcr.io","token":"***********"}]},"msg":"File config","time":"2021-10-15T13:55:04.241Z","v":0}
{"config":{},"msg":"CLI config","time":"2021-10-15T13:55:04.242Z","v":0}
{"config":{"hostRules":[{"hostType":"npm","matchHost":"npm.pkg.github.com","token":"***********"}],"repositoryCache":"enabled","redisUrl":"redis://redis.my-od/15","baseDir":"/opt/renovate","onboarding":false,"requireConfig":false,"persistRepoData":true,"platform":"github","token":"***********","autodiscover":false,"prCommitsPerRunLimit":120,"repositories":["redacted/techops-snipeit"],"gitAuthor":"Renovate Bot <renovate@whitesourcesoftware.com>"},"msg":"Env config","time":"2021-10-15T13:55:04.243Z","v":0}
{"config":{"extends":["config:base"],"allowPostUpgradeCommandTemplating":true,"allowedPostUpgradeCommands":["^bash"],"binarySource":"docker","enabledManagers":["regex"],"regexManagers":[{"fileMatch":["(^|/)\\.pre-commit-config\\.yaml$"],"matchStrings":["repo: (?<depName>.{2,}?)\n\\s+rev: (?<currentDigest>.*?)\n"],"datasourceTemplate":"git-refs","versioningTemplate":"git"}],"packageRules":[{"matchPaths":[".pre-commit-config.yaml"],"matchUpdateTypes":["digest"],"labels":["renovate","renovate-pre-commit"],"prBodyTemplate":"{{{table}}}{{{notes}}}{{{changelogs}}}"}],"npmrc":"***********","labels":["renovate"],"timezone":"Europe/Berlin","hostRules":[{"matchHost":"eu.gcr.io","token":"***********"},{"hostType":"npm","matchHost":"npm.pkg.github.com","token":"***********"}],"repositoryCache":"enabled","redisUrl":"redis://redis.my-od/15","baseDir":"/opt/renovate","onboarding":false,"requireConfig":false,"persistRepoData":true,"platform":"github","token":"***********","autodiscover":false,"prCommitsPerRunLimit":120,"repositories":["redacted/techops-snipeit"],"gitAuthor":"Renovate Bot <renovate@whitesourcesoftware.com>"},"msg":"Combined config","time":"2021-10-15T13:55:04.244Z","v":0}
{"msg":"Using default github endpoint: https://api.github.com/","time":"2021-10-15T13:55:04.246Z","v":0}
{"msg":"Authenticated as GitHub user: redacted","time":"2021-10-15T13:55:04.663Z","v":0}
{"msg":"Using configured gitAuthor (Renovate Bot <renovate@whitesourcesoftware.com>)","time":"2021-10-15T13:55:04.664Z","v":0}
{"msg":"Adding token authentication for api.github.com to hostRules","time":"2021-10-15T13:55:04.699Z","v":0}
{"msg":"Using configured baseDir: /opt/renovate","time":"2021-10-15T13:55:04.701Z","v":0}
{"msg":"Using cacheDir: /opt/renovate/cache","time":"2021-10-15T13:55:04.704Z","v":0}
{"msg":"Redis cache init","time":"2021-10-15T13:55:04.705Z","v":0}
{"msg":"Commits limit = 120","time":"2021-10-15T13:55:04.709Z","v":0}
{"msg":"Clearing hostRules","time":"2021-10-15T13:55:05.018Z","v":0}
{"msg":"Adding token authentication for eu.gcr.io to hostRules","time":"2021-10-15T13:55:05.020Z","v":0}
{"msg":"Adding token authentication for npm.pkg.github.com to hostRules","time":"2021-10-15T13:55:05.021Z","v":0}
{"msg":"Adding token authentication for api.github.com to hostRules","time":"2021-10-15T13:55:05.022Z","v":0}
{"msg":"No dangling containers to remove","time":"2021-10-15T13:55:05.135Z","v":0}
{"renovateVersion":"28.1.3","msg":"Repository started","time":"2021-10-15T13:55:05.136Z","v":0}

{"msg":"Using localDir: /opt/renovate/repos/github/redacted/techops-snipeit","time":"2021-10-15T13:55:05.138Z","v":0}
{"msg":"Repository cache is valid","time":"2021-10-15T13:55:05.145Z","v":0}
{"msg":"initRepo(\"redacted/techops-snipeit\")","time":"2021-10-15T13:55:05.150Z","v":0}
{"endpoint":"https://api.github.com/","msg":"Overriding default GitHub endpoint","time":"2021-10-15T13:55:05.151Z","v":0}
{"msg":"redacted/techops-snipeit default branch = master","time":"2021-10-15T13:55:05.677Z","v":0}
{"msg":"Using personal access token for git init","time":"2021-10-15T13:55:05.678Z","v":0}
{"msg":"resetMemCache()","time":"2021-10-15T13:55:06.457Z","v":0}
{"msg":"Setting npmrc","time":"2021-10-15T13:55:06.458Z","v":0}
{"msg":"checkOnboarding()","time":"2021-10-15T13:55:06.460Z","v":0}
{"msg":"isOnboarded()","time":"2021-10-15T13:55:06.460Z","v":0}
{"msg":"Repo is onboarded","time":"2021-10-15T13:55:06.460Z","v":0}
{"msg":"migrateAndValidate()","time":"2021-10-15T13:55:06.863Z","v":0}
{"msg":"No config migration necessary","time":"2021-10-15T13:55:06.863Z","v":0}
{"config":{"extends":["config:base","github>redacted/devops-renovate-shared-config:default"]},"msg":"massaged config","time":"2021-10-15T13:55:06.864Z","v":0}
{"config":{"extends":["config:base","github>redacted/devops-renovate-shared-config:default"]},"msg":"migrated config","time":"2021-10-15T13:55:06.866Z","v":0}
{"msg":"Setting hostRules from config","time":"2021-10-15T13:55:07.767Z","v":0}
{"ignorePaths":["**/node_modules/**","**/bower_components/**","**/vendor/**","**/examples/**","**/__tests__/**","**/test/**","**/tests/**","**/__fixtures__/**"],"msg":"Found repo ignorePaths","time":"2021-10-15T13:55:07.783Z","v":0}
{"msg":"No vulnerability alerts found","time":"2021-10-15T13:55:08.209Z","v":0}
{"msg":"No vulnerability alerts found","time":"2021-10-15T13:55:08.209Z","v":0}
{"msg":"findIssue(Dependency Dashboard)","time":"2021-10-15T13:55:08.211Z","v":0}
{"msg":"Retrieving issueList","time":"2021-10-15T13:55:08.212Z","v":0}
{"msg":"Retrieved 0 issues","time":"2021-10-15T13:55:08.668Z","v":0}
{"msg":"No baseBranches","time":"2021-10-15T13:55:08.668Z","v":0}
{"msg":"extract()","time":"2021-10-15T13:55:08.669Z","v":0}
{"baseBranch":"master","baseBranchSha":"84b3308796f4c5ffc039ba4c71d4a3c3b4fe8da4","msg":"Found cached extract","time":"2021-10-15T13:55:08.671Z","v":0}
{"msg":"Deleted cached dep updates","time":"2021-10-15T13:55:08.672Z","v":0}
{"name":"renovate","hostname":"renovate-test-manual-qq4-n6dn7","pid":15,"level":30,"logContext":"cI4fzl0iE","repository":"redacted/techops-snipeit","baseBranch":"master","stats":{"managers":{"docker-compose":{"fileCount":1,"depCount":2},"kubernetes":{"fileCount":2,"depCount":14},"kustomize":{"fileCount":2,"depCount":3},"regex":{"fileCount":1,"depCount":1}},"total":{"fileCount":6,"depCount":20}},"msg":"Dependency extraction complete","time":"2021-10-15T13:55:08.672Z","v":0}
{"msg":"getLabels(https://index.docker.io, snipe/snipe-it, latest)","time":"2021-10-15T13:55:08.858Z","v":0}
{"msg":"getLabels(https://index.docker.io, library/mariadb, latest)","time":"2021-10-15T13:55:10.133Z","v":0}
{"baseBranch":"master","msg":"Package releases lookups complete","time":"2021-10-15T13:55:10.352Z","v":0}
{"msg":"branchifyUpgrades","time":"2021-10-15T13:55:10.353Z","v":0}
{"msg":"1 flattened updates found: git@github.com:redacted/devops-pre-commit.git","time":"2021-10-15T13:55:10.476Z","v":0}
{"msg":"Returning 1 branch(es)","time":"2021-10-15T13:55:10.478Z","v":0}
{"msg":"config.repoIsOnboarded=true","time":"2021-10-15T13:55:10.527Z","v":0}
{"config":{"docker-compose":[{"packageFile":"docker-compose.yml","deps":[{"depName":"mariadb","currentValue":"10.6.4","replaceString":"mariadb:10.6.4","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":0,"warnings":[],"versioning":"docker","currentVersion":"10.6.4","fixedVersion":"10.6.4","updates":[]},{"depName":"snipe/snipe-it","currentValue":"v5.1.8","replaceString":"snipe/snipe-it:v5.1.8","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":1,"warnings":[],"versioning":"docker","currentVersion":"v5.1.8","fixedVersion":"v5.1.8","updates":[]}]}],"kubernetes":[{"packageFile":"kubernetes/base/deployment.yaml","deps":[{"depName":"snipe-it","replaceString":"snipe-it","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":0,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"busybox","replaceString":"busybox","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":1,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"snipe-it","replaceString":"snipe-it","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":2,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"snipe-it","replaceString":"snipe-it","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":3,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"snipe-it","replaceString":"snipe-it","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":4,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"busybox","replaceString":"busybox","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":5,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"snipe-it","replaceString":"snipe-it","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":6,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"busybox","replaceString":"busybox","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":7,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"snipe-it","replaceString":"snipe-it","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":8,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"snipe-it","replaceString":"snipe-it","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":9,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"snipe-it","replaceString":"snipe-it","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":10,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"busybox","replaceString":"busybox","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":11,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]}]},{"packageFile":"kubernetes/overlays/minikube/mysql.yaml","deps":[{"depName":"mariadb","replaceString":"mariadb","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":0,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"mariadb","replaceString":"mariadb","autoReplaceStringTemplate":"{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}","datasource":"docker","depIndex":1,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]}]}],"kustomize":[{"packageFile":"kubernetes/base/kustomization.yaml","deps":[{"depName":"busybox","currentValue":"latest","datasource":"docker","replaceString":"latest","depIndex":0,"warnings":[],"versioning":"docker","skipReason":"invalid-value","updates":[]},{"depName":"snipe/snipe-it","currentValue":"v5.1.8","datasource":"docker","replaceString":"v5.1.8","depIndex":1,"warnings":[],"versioning":"docker","currentVersion":"v5.1.8","fixedVersion":"v5.1.8","updates":[]}]},{"packageFile":"kubernetes/overlays/minikube/kustomization.yaml","deps":[{"depName":"mariadb","currentValue":"10.6.4","datasource":"docker","replaceString":"10.6.4","depIndex":0,"warnings":[],"versioning":"docker","currentVersion":"10.6.4","fixedVersion":"10.6.4","updates":[]}]}],"regex":[{"packageFile":".pre-commit-config.yaml","deps":[{"depName":"git@github.com:redacted/devops-pre-commit.git","currentDigest":"5c6fe85caa467c885705044f4271972a29f65e21","datasource":"git-refs","versioning":"git","replaceString":"repo: git@github.com:redacted/devops-pre-commit.git\n    rev: 5c6fe85caa467c885705044f4271972a29f65e21\n","depIndex":0,"warnings":[],"updates":[{"updateType":"digest","newDigest":"2efba66b2fc647506344f8471c024c0bf4ac8657","branchName":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest"}]}],"matchStrings":["repo: (?<depName>.{2,}?)\n\\s+rev: (?<currentDigest>.*?)\n"],"datasourceTemplate":"git-refs","versioningTemplate":"git"}]},"msg":"packageFiles with updates","time":"2021-10-15T13:55:10.529Z","v":0}
{"msg":"processRepo()","time":"2021-10-15T13:55:10.532Z","v":0}
{"msg":"Processing 1 branch: renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","time":"2021-10-15T13:55:10.533Z","v":0}
{"msg":"Calculating hourly PRs remaining","time":"2021-10-15T13:55:10.534Z","v":0}
{"msg":"Retrieving PR list","time":"2021-10-15T13:55:10.534Z","v":0}
{"msg":"Retrieved 7 Pull Requests","time":"2021-10-15T13:55:12.066Z","v":0}
{"msg":"currentHourStart=2021-10-15T13:00:00.000+00:00","time":"2021-10-15T13:55:12.067Z","v":0}
{"msg":"PR hourly limit remaining: 2","time":"2021-10-15T13:55:12.069Z","v":0}
{"msg":"Calculating prConcurrentLimit (20)","time":"2021-10-15T13:55:12.070Z","v":0}
{"msg":"getBranchPr(renovate/gitgithub.com-redacted-devops-pre-commit.git-digest)","time":"2021-10-15T13:55:12.070Z","v":0}
{"msg":"findPr(renovate/gitgithub.com-redacted-devops-pre-commit.git-digest, undefined, open)","time":"2021-10-15T13:55:12.071Z","v":0}
{"msg":"Found PR #44","time":"2021-10-15T13:55:12.072Z","v":0}
{"msg":"Returning from graphql open PR list","time":"2021-10-15T13:55:12.941Z","v":0}
{"msg":"1 PRs are currently open","time":"2021-10-15T13:55:12.942Z","v":0}
{"msg":"PR concurrent limit remaining: 19","time":"2021-10-15T13:55:12.942Z","v":0}
{"prsRemaining":2,"msg":"Calculated maximum PRs remaining this run","time":"2021-10-15T13:55:12.942Z","v":0}
{"msg":"PullRequests limit = 2","time":"2021-10-15T13:55:12.943Z","v":0}
{"msg":"Calculating hourly PRs remaining","time":"2021-10-15T13:55:12.943Z","v":0}
{"msg":"currentHourStart=2021-10-15T13:00:00.000+00:00","time":"2021-10-15T13:55:12.943Z","v":0}
{"msg":"PR hourly limit remaining: 2","time":"2021-10-15T13:55:12.944Z","v":0}
{"msg":"Calculating branchConcurrentLimit (20)","time":"2021-10-15T13:55:12.945Z","v":0}
{"msg":"1 already existing branches found: renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","time":"2021-10-15T13:55:12.945Z","v":0}
{"msg":"Branch concurrent limit remaining: 19","time":"2021-10-15T13:55:12.945Z","v":0}
{"branchesRemaining":2,"msg":"Calculated maximum branches remaining this run","time":"2021-10-15T13:55:12.945Z","v":0}
{"msg":"Branches limit = 2","time":"2021-10-15T13:55:12.946Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Setting current branch to master","time":"2021-10-15T13:55:12.948Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Initializing git repository into /opt/renovate/repos/github/redacted/techops-snipeit","time":"2021-10-15T13:55:12.949Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"resetToBranch(master)","time":"2021-10-15T13:55:13.046Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"resetToBranch(master)","time":"2021-10-15T13:55:14.915Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","existingBranches":["renovate/gitgithub.com-redacted-devops-pre-commit.git-digest"],"msg":"","time":"2021-10-15T13:55:15.073Z","v":0}
{"name":"renovate","hostname":"renovate-test-manual-qq4-n6dn7","pid":15,"level":30,"logContext":"cI4fzl0iE","repository":"redacted/techops-snipeit","branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","durationMs":2695,"msg":"git fetch completed","time":"2021-10-15T13:55:15.909Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","latestCommit":{"hash":"84b3308796f4c5ffc039ba4c71d4a3c3b4fe8da4","date":"2021-10-13T16:35:18+02:00","message":"Merge pull request #43 from redacted/renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","refs":"HEAD -> master, origin/master, origin/HEAD","body":"Update git@github.com:redacted/devops-pre-commit.git commit hash to 5c6fe85","author_name":"redacted","author_email":"46893663+redacted@users.noreply.github.com"},"msg":"latest repository commit","time":"2021-10-15T13:55:15.955Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","branchName":"master","latestCommitDate":"2021-10-13T16:35:18+02:00","msg":"latest commit","time":"2021-10-15T13:55:16.037Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"branchExists=true","time":"2021-10-15T13:55:16.077Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"dependencyDashboardCheck=undefined","time":"2021-10-15T13:55:16.078Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"PR rebase requested=false","time":"2021-10-15T13:55:16.078Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Checking if PR has been edited","time":"2021-10-15T13:55:16.091Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Found existing branch PR","time":"2021-10-15T13:55:16.112Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Checking schedule(at any time, Europe/Berlin)","time":"2021-10-15T13:55:16.113Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"No schedule defined","time":"2021-10-15T13:55:16.113Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Branch already exists","time":"2021-10-15T13:55:16.115Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Found branch protection","time":"2021-10-15T13:55:16.515Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Branch protection: PR Reviews are required before merging","time":"2021-10-15T13:55:16.515Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Skipping stale branch check due to rebaseWhen=auto","time":"2021-10-15T13:55:16.515Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Branch does not need rebasing","time":"2021-10-15T13:55:16.515Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Using reuseExistingBranch: true","time":"2021-10-15T13:55:16.516Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"manager.getUpdatedPackageFiles() reuseExistinbranch=true","time":"2021-10-15T13:55:16.517Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","packageFile":".pre-commit-config.yaml","depName":"git@github.com:redacted/devops-pre-commit.git","msg":"Rebasing after outdated branch dep found","time":"2021-10-15T13:55:16.551Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"manager.getUpdatedPackageFiles() reuseExistinbranch=false","time":"2021-10-15T13:55:16.551Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","packageFile":".pre-commit-config.yaml","depName":"git@github.com:redacted/devops-pre-commit.git","msg":"Starting search at index 15","time":"2021-10-15T13:55:16.575Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","packageFile":".pre-commit-config.yaml","depName":"git@github.com:redacted/devops-pre-commit.git","msg":"Found match at index 15","time":"2021-10-15T13:55:16.575Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","packageFile":".pre-commit-config.yaml","depName":"git@github.com:redacted/devops-pre-commit.git","msg":"Contents updated","time":"2021-10-15T13:55:16.585Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Updated 1 package files","time":"2021-10-15T13:55:16.587Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"No updated lock files in branch","time":"2021-10-15T13:55:16.590Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"1 file(s) to commit","time":"2021-10-15T13:55:16.593Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Committing files to branch renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","time":"2021-10-15T13:55:16.595Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","gitAuthorName":"Renovate Bot","msg":"Setting git author name","time":"2021-10-15T13:55:16.596Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","gitAuthorEmail":"renovate@whitesourcesoftware.com","msg":"Setting git author email","time":"2021-10-15T13:55:16.680Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","deletedFiles":[],"ignoredFiles":[],"result":{"author":null,"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","commit":"d8f85b1","root":false,"summary":{"changes":1,"insertions":1,"deletions":1}},"msg":"git commit","time":"2021-10-15T13:55:17.024Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Branch update was rejected because local copy is not up-to-date.","time":"2021-10-15T13:55:17.665Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Checking if we can automerge branch","time":"2021-10-15T13:55:17.668Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"mergeStatus=no automerge","time":"2021-10-15T13:55:17.669Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Ensuring PR","time":"2021-10-15T13:55:17.669Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"There are 0 errors and 0 warnings","time":"2021-10-15T13:55:17.670Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Found existing PR","time":"2021-10-15T13:55:17.675Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Processing existing PR","time":"2021-10-15T13:55:17.732Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Pull Request #44 does not need updating","time":"2021-10-15T13:55:17.733Z","v":0}
{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"PR is not configured for automerge","time":"2021-10-15T13:55:17.734Z","v":0}
{"msg":"Ensuring Dependency Dashboard","time":"2021-10-15T13:55:17.757Z","v":0}
{"msg":"ensureIssue(Dependency Dashboard)","time":"2021-10-15T13:55:17.760Z","v":0}
{"msg":"Issues are disabled, so could not create issue: Dependency Dashboard","time":"2021-10-15T13:55:18.123Z","v":0}
{"msg":"Removing any stale branches","time":"2021-10-15T13:55:18.134Z","v":0}
{"msg":"config.repoIsOnboarded=true","time":"2021-10-15T13:55:18.134Z","v":0}
{"branchList":["renovate/gitgithub.com-redacted-devops-pre-commit.git-digest"],"renovateBranches":["renovate/gitgithub.com-redacted-devops-pre-commit.git-digest"],"msg":"Branch lists","time":"2021-10-15T13:55:18.138Z","v":0}
{"msg":"remainingBranches=","time":"2021-10-15T13:55:18.139Z","v":0}
{"msg":"No branches to clean up","time":"2021-10-15T13:55:18.140Z","v":0}
{"splits":{"init":3188,"extract":462,"lookup":1859,"update":7204},"total":13121,"msg":"Repository timing splits (milliseconds)","time":"2021-10-15T13:55:18.143Z","v":0}
{"urls":{"https://api.github.com/graphql (POST)":4,"https://api.github.com/repos/redacted/devops-renovate-shared-config/contents/default.json (GET)":1,"https://api.github.com/repos/redacted/techops-snipeit/branches/master/protection (GET)":1,"https://api.github.com/repos/redacted/techops-snipeit/contents/renovate.json (GET)":1,"https://api.github.com/repos/redacted/techops-snipeit/pulls (GET)":1,"https://auth.docker.io/token (GET)":1,"https://index.docker.io/v2/ (GET)":1,"https://index.docker.io/v2/library/mariadb/tags/list (GET)":1},"hostStats":{"api.github.com":{"requestCount":8,"requestAvgMs":598,"queueAvgMs":0},"auth.docker.io":{"requestCount":1,"requestAvgMs":373,"queueAvgMs":6},"index.docker.io":{"requestCount":2,"requestAvgMs":430,"queueAvgMs":2}},"totalRequests":11,"msg":"http statistics","time":"2021-10-15T13:55:18.147Z","v":0}
{"durationMs":13121,"msg":"Repository finished","time":"2021-10-15T13:55:18.147Z","v":0}
{"msg":"Renovate exiting","time":"2021-10-15T13:55:18.149Z","v":0}

Note the

{"branch":"renovate/gitgithub.com-redacted-devops-pre-commit.git-digest","msg":"Branch update was rejected because local copy is not up-to-date.","time":"2021-10-15T13:55:17.665Z","v":0}

@rarkins
Copy link
Collaborator

rarkins commented Oct 15, 2021

So I guess we should try avoiding updating the PR if a branch update failed.

@rarkins rarkins added priority-2-high Bugs impacting wide number of users or very important features status:ready and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Oct 15, 2021
@giannello
Copy link

any chance to have more info on why the push has failed?
Also, deleting the local copy of the repo and re-triggering Renovate fixes the issue.

@rarkins
Copy link
Collaborator

rarkins commented Oct 15, 2021

any chance to have more info on why the push has failed?

No, the error message is descriptive enough and also easily findable in the source code yourself.

@rarkins
Copy link
Collaborator

rarkins commented Dec 11, 2021

Is there any easy way we can reproduce this problem locally?

One idea I have: run it in the debugger, with a pause sometime prior to the commit/push. Then intentionally edit the same branch on GitHub.com before resuming. This might be enough to cause the push --with-lease to fail.

@wwuck
Copy link
Contributor

wwuck commented Dec 13, 2021

I'm not sure if I'm seeing the same problem on self-hosted renovate (30.0.0-slim docker) or if it's a different bug.

I have a packageRules enabled to group multiple packages, and renovate creates the initial PR for one dependency in the group. When a second dependency in the group is updated, renovate will rebase and change the PR title but the PR body message is not changed to include the new dependency update. The PR body is left unchanged with only the update information for the initial dependency update.

@rarkins
Copy link
Collaborator

rarkins commented Dec 13, 2021

No, that's a different problem

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 31.82.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants