Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending a nonexistent message type should throw #926

Open
jespertheend opened this issue Apr 11, 2024 · 1 comment
Open

Sending a nonexistent message type should throw #926

jespertheend opened this issue Apr 11, 2024 · 1 comment
Labels
effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase topic: TypedMessenger Related to the TypedMessenger class.
Milestone
V1.0

Comments

@jespertheend
Copy link
Collaborator

When calling TypedMessenger.send.someNonexistentFunction() it should reject with an error indicating that the function doesn't exist.
@jespertheend jespertheend added effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase topic: TypedMessenger Related to the TypedMessenger class. labels Apr 11, 2024
@jespertheend jespertheend added this to the V1.0 milestone Apr 11, 2024
@jespertheend
Copy link
Collaborator Author

On the other hand, sometimes not throwing might be desired. For instance, if an application wishes to notify another application (with an older version) about a change, it might be completely fine if that message type doesn't exist. Although in that case respond is probably set to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase topic: TypedMessenger Related to the TypedMessenger class.
Projects
None yet
Milestone
V1.0
Development

No branches or pull requests
1 participant
@jespertheend