Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenSize view uniform should be an integer #921

Open
jespertheend opened this issue Apr 6, 2024 · 0 comments
Open

screenSize view uniform should be an integer #921

jespertheend opened this issue Apr 6, 2024 · 0 comments
Labels
effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase topic: WebGPU Renderer Related to the WebGpuRenderer
Milestone

Comments

@jespertheend
Copy link
Collaborator

Currently it's a vec4<f32> but since the screen size can't half pixels, an integer type would be more suitable here.

Although the z and w components of the vector are unused right now. We might want to provide something useful here.
Unity stores 1.0 + 1.0/w here for instance. If we decide to do this, an integer type wouldn't work.

@jespertheend jespertheend added effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase topic: WebGPU Renderer Related to the WebGpuRenderer labels Apr 6, 2024
@jespertheend jespertheend added this to the V1.0 milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase topic: WebGPU Renderer Related to the WebGpuRenderer
Projects
None yet
Development

No branches or pull requests

1 participant