Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up studio connections when they are closed #857

Open
jespertheend opened this issue Jan 7, 2024 · 0 comments
Open

Clean up studio connections when they are closed #857

jespertheend opened this issue Jan 7, 2024 · 0 comments
Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Studio Connections Related to messaging connection discovery between studio instances or inspectors.
Milestone
V1.0

Comments

@jespertheend
Copy link
Collaborator

Right now the StudioConnectionsManager has a set of this.#activeConnections, but when a connection is closed they are not removed from this set.
Similarly, the onChange event that is registered on file systems is not cleaned up either.
@jespertheend jespertheend added effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Studio Connections Related to messaging connection discovery between studio instances or inspectors. labels Jan 7, 2024
@jespertheend jespertheend added this to the V1.0 milestone Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Studio Connections Related to messaging connection discovery between studio instances or inspectors.
Projects
None yet
Milestone
V1.0
Development

No branches or pull requests
1 participant
@jespertheend