Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't destroy placeholder texture references until the end of a frame. #823

Open
jespertheend opened this issue Nov 24, 2023 · 0 comments
Open
Labels
effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase topic: WebGPU Renderer Related to the WebGpuRenderer
Milestone

Comments

@jespertheend
Copy link
Collaborator

Right now the placeholder textures of a material are destroyed right after the new ones have been created for that material.
But this makes it possible for there to be a brief moment where there are no references for that color, even though right after that another material could potentially create a new reference with the same color.

Ideally all the placeholder texture references of each material are collected while a frame is being rendered, and at the very end of the render call the reference is removed.

@jespertheend jespertheend added effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase topic: WebGPU Renderer Related to the WebGpuRenderer labels Nov 24, 2023
@jespertheend jespertheend added this to the backlog milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase topic: WebGPU Renderer Related to the WebGpuRenderer
Projects
None yet
Development

No branches or pull requests

1 participant